Bug 152394 - [Win] Prevent flashing/strobe repaints on certain hardware
Summary: [Win] Prevent flashing/strobe repaints on certain hardware
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: Layout and Rendering (show other bugs)
Version: WebKit Nightly Build
Hardware: PC All
: P2 Normal
Assignee: Brent Fulgham
URL:
Keywords: InRadar
Depends on:
Blocks:
 
Reported: 2015-12-17 13:25 PST by Brent Fulgham
Modified: 2015-12-17 14:26 PST (History)
4 users (show)

See Also:

Attachments
Patch (1.48 KB, patch)
2015-12-17 13:33 PST, Brent Fulgham 		no flags Details | Formatted Diff | Diff
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Brent Fulgham 2015-12-17 13:25:00 PST 
Further testing on a variety of Windows hardware shows that the changes in Bug 151001 seemed to cause a "flashing" repaint to occur on certain web content under Accelerated Compositing on certain Windows configurations.

We eventually tracked this down to my change in WKCACFViewLayerTreeHostcpp, which I changed to be more pessimistic about when repaints were needed. Once this change was reverted, the strobing problem went away.
Comment 1 Brent Fulgham 2015-12-17 13:28:53 PST 
<rdar://problem/23875302>
Comment 2 Brent Fulgham 2015-12-17 13:33:56 PST 
Created attachment 267581 [details]
Patch
Comment 3 WebKit Commit Bot 2015-12-17 14:26:43 PST 
Comment on attachment 267581 [details]
Patch

Clearing flags on attachment: 267581

Committed r194235: <http://trac.webkit.org/changeset/194235>
Comment 4 WebKit Commit Bot 2015-12-17 14:26:46 PST 
All reviewed patches have been landed.  Closing bug.