Bug 152385 – [ES6] Catch parameter should accept BindingPattern

• Status: RESOLVED
• Resolution: FIXED
• Component: JavaScriptCore

[Yusuke Suzuki]

...

[Yusuke Suzuki]

Created attachment 269455 [details]
Patch

[Saam Barati]

Comment on attachment 269455 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=269455&action=review

r=me

> Source/JavaScriptCore/tests/stress/catch-parameter-syntax.js:27
> +    } catch ([a, a]) {

Is this definitely disallowed by the spec?

[Saam Barati]

Comment on attachment 269455 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=269455&action=review

r=me

> Source/JavaScriptCore/tests/stress/catch-parameter-syntax.js:27
> +    } catch ([a, a]) {

Is this definitely disallowed by the spec?

[Build Bot]

Comment on attachment 269455 [details]
Patch

Attachment 269455 [details] did not pass mac-wk2-ews (mac-wk2):
Output: http://webkit-queues.webkit.org/results/722079

New failing tests:
sputnik/Conformance/12_Statement/12.14_The_try_Statement/S12.14_A16_T7.html
sputnik/Conformance/12_Statement/12.14_The_try_Statement/S12.14_A16_T13.html
js/mozilla/strict/12.14.1.html
sputnik/Conformance/12_Statement/12.14_The_try_Statement/S12.14_A16_T5.html
sputnik/Conformance/12_Statement/12.14_The_try_Statement/S12.14_A16_T8.html
js/dom/reserved-words-as-property.html
sputnik/Conformance/12_Statement/12.14_The_try_Statement/S12.14_A16_T10.html

[Build Bot]

Created attachment 269458 [details]
Archive of layout-test-results from ews105 for mac-yosemite-wk2

The attached test failures were seen while running run-webkit-tests on the mac-wk2-ews.
Bot: ews105  Port: mac-yosemite-wk2  Platform: Mac OS X 10.10.5

[Yusuke Suzuki]

Comment on attachment 269455 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=269455&action=review

Thanks!! Before landing, I'll update the test expect files (since failure in layout tests is due to missing test expect file updates)

>>> Source/JavaScriptCore/tests/stress/catch-parameter-syntax.js:27
>>> +    } catch ([a, a]) {
>> 
>> Is this definitely disallowed by the spec?
> 
> Is this definitely disallowed by the spec?

Yup! "It is a Syntax Error if BoundNames of CatchParameter contains any duplicate elements."
http://ecma-international.org/ecma-262/6.0/#sec-try-statement-static-semantics-early-errors

[Build Bot]

Comment on attachment 269455 [details]
Patch

Attachment 269455 [details] did not pass mac-ews (mac):
Output: http://webkit-queues.webkit.org/results/722144

New failing tests:
sputnik/Conformance/12_Statement/12.14_The_try_Statement/S12.14_A16_T7.html
sputnik/Conformance/12_Statement/12.14_The_try_Statement/S12.14_A16_T13.html
js/mozilla/strict/12.14.1.html
sputnik/Conformance/12_Statement/12.14_The_try_Statement/S12.14_A16_T5.html
sputnik/Conformance/12_Statement/12.14_The_try_Statement/S12.14_A16_T8.html
js/dom/reserved-words-as-property.html
sputnik/Conformance/12_Statement/12.14_The_try_Statement/S12.14_A16_T10.html

[Build Bot]

Created attachment 269459 [details]
Archive of layout-test-results from ews102 for mac-yosemite

The attached test failures were seen while running run-webkit-tests on the mac-ews.
Bot: ews102  Port: mac-yosemite  Platform: Mac OS X 10.10.5

[Build Bot]

Comment on attachment 269455 [details]
Patch

Attachment 269455 [details] did not pass mac-debug-ews (mac):
Output: http://webkit-queues.webkit.org/results/722133

New failing tests:
sputnik/Conformance/12_Statement/12.14_The_try_Statement/S12.14_A16_T7.html
sputnik/Conformance/12_Statement/12.14_The_try_Statement/S12.14_A16_T13.html
js/mozilla/strict/12.14.1.html
sputnik/Conformance/12_Statement/12.14_The_try_Statement/S12.14_A16_T5.html
sputnik/Conformance/12_Statement/12.14_The_try_Statement/S12.14_A16_T8.html
js/dom/reserved-words-as-property.html
sputnik/Conformance/12_Statement/12.14_The_try_Statement/S12.14_A16_T10.html

[Build Bot]

Created attachment 269461 [details]
Archive of layout-test-results from ews117 for mac-yosemite

The attached test failures were seen while running run-webkit-tests on the mac-debug-ews.
Bot: ews117  Port: mac-yosemite  Platform: Mac OS X 10.10.5

[Yusuke Suzuki]

Created attachment 269467 [details]
Patch

revised, checking on EWS

[Yusuke Suzuki]

Oops. I should add "--no-obsolute"... Anyway, after checking EWS, I'll land it :)

[Yusuke Suzuki]

Committed r195439: <http://trac.webkit.org/changeset/195439>