Bug 152375 - [iOS] Block loading external stylesheets in the Content-Disposition: attachment sandbox
Summary: [iOS] Block loading external stylesheets in the Content-Disposition: attachme...
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: New Bugs (show other bugs)
Version: WebKit Nightly Build
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Andy Estes
URL:
Keywords: InRadar
Depends on:
Blocks:
 
Reported: 2015-12-16 19:34 PST by Andy Estes
Modified: 2015-12-16 21:54 PST (History)
11 users (show)

See Also:

Attachments
Patch (15.42 KB, patch)
2015-12-16 19:42 PST, Andy Estes 		darin: review+
Details | Formatted Diff | Diff
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Andy Estes 2015-12-16 19:34:07 PST 
[iOS] Block loading external stylesheets in the Content-Disposition: attachment sandbox
Comment 1 Andy Estes 2015-12-16 19:38:22 PST 
rdar://problem/22020902
Comment 2 Andy Estes 2015-12-16 19:42:16 PST 
Created attachment 267527 [details]
Patch
Comment 3 Darin Adler 2015-12-16 21:34:00 PST 
Comment on attachment 267527 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=267527&action=review

> Source/WebCore/loader/cache/CachedResourceLoader.cpp:475
> +    Document* document = nullptr;

I don’t think we need to initialize document here. It’s initialized in all code paths below.

> Source/WebCore/loader/cache/CachedResourceLoader.h:134
> +    bool canRequestInContentDispositionAttachmentSandbox(CachedResource::Type, const URL&) const;

I suggest making this private rather than public.
Comment 4 Andy Estes 2015-12-16 21:54:06 PST 
Committed r194209: <http://trac.webkit.org/changeset/194209>