WebKit Bugzilla
New
Browse
Log In
×
Sign in with GitHub
or
Remember my login
Create Account
·
Forgot Password
Forgotten password account recovery
RESOLVED FIXED
152375
[iOS] Block loading external stylesheets in the Content-Disposition: attachment sandbox
https://bugs.webkit.org/show_bug.cgi?id=152375
Summary
[iOS] Block loading external stylesheets in the Content-Disposition: attachme...
Andy Estes
Reported
2015-12-16 19:34:07 PST
[iOS] Block loading external stylesheets in the Content-Disposition: attachment sandbox
Attachments
Patch
(15.42 KB, patch)
2015-12-16 19:42 PST
,
Andy Estes
darin
: review+
Details
Formatted Diff
Diff
View All
Add attachment
proposed patch, testcase, etc.
Andy Estes
Comment 1
2015-12-16 19:38:22 PST
rdar://problem/22020902
Andy Estes
Comment 2
2015-12-16 19:42:16 PST
Created
attachment 267527
[details]
Patch
Darin Adler
Comment 3
2015-12-16 21:34:00 PST
Comment on
attachment 267527
[details]
Patch View in context:
https://bugs.webkit.org/attachment.cgi?id=267527&action=review
> Source/WebCore/loader/cache/CachedResourceLoader.cpp:475 > + Document* document = nullptr;
I don’t think we need to initialize document here. It’s initialized in all code paths below.
> Source/WebCore/loader/cache/CachedResourceLoader.h:134 > + bool canRequestInContentDispositionAttachmentSandbox(CachedResource::Type, const URL&) const;
I suggest making this private rather than public.
Andy Estes
Comment 4
2015-12-16 21:54:06 PST
Committed
r194209
: <
http://trac.webkit.org/changeset/194209
>
Note
You need to
log in
before you can comment on or make changes to this bug.
Top of Page
Format For Printing
XML
Clone This Bug