Bug 152374 - Reduce resource usage when copying image to clipboard
Summary: Reduce resource usage when copying image to clipboard
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: Images (show other bugs)
Version: WebKit Local Build
Hardware: Mac OS X 10.11
: P2 Normal
Assignee: Nobody
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2015-12-16 19:17 PST by Jeremy Zerfas
Modified: 2015-12-20 20:23 PST (History)
2 users (show)

See Also:


Attachments
Patch to reduce resource usage when copying image to clipboard. (13.71 KB, patch)
2015-12-16 19:35 PST, Jeremy Zerfas
no flags Details | Formatted Diff | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Jeremy Zerfas 2015-12-16 19:17:18 PST
When copying an image to the clipboard on current versions of WebKit on Mac OS X, there is an unnecessary NSImage allocation and call to TIFFRepresentation. This results in more memory and CPU time being used than is necessary (particularly for animated GIFs). I will be adding a patch for this shortly which will remove the NSImage allocation and TIFFRepresentation call. This is also somewhat related to bug 125868 and bug 131576.
Comment 1 Jeremy Zerfas 2015-12-16 19:35:59 PST
Created attachment 267526 [details]
Patch to reduce resource usage when copying image to clipboard.
Comment 2 Darin Adler 2015-12-16 21:27:00 PST
Comment on attachment 267526 [details]
Patch to reduce resource usage when copying image to clipboard.

Why do I feel like I’ve seen this patch before?
Comment 3 Darin Adler 2015-12-16 21:27:26 PST
Oh, I remember. It was in bug 125868.
Comment 4 WebKit Commit Bot 2015-12-20 20:23:35 PST
Comment on attachment 267526 [details]
Patch to reduce resource usage when copying image to clipboard.

Clearing flags on attachment: 267526

Committed r194326: <http://trac.webkit.org/changeset/194326>
Comment 5 WebKit Commit Bot 2015-12-20 20:23:39 PST
All reviewed patches have been landed.  Closing bug.