Bug 152371 - Progress towards implementing downloads with NetworkSession
Summary: Progress towards implementing downloads with NetworkSession
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: New Bugs (show other bugs)
Version: WebKit Nightly Build
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Alex Christensen
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2015-12-16 18:14 PST by Alex Christensen
Modified: 2015-12-16 23:10 PST (History)
0 users

See Also:

Attachments
Patch (24.86 KB, patch)
2015-12-16 18:14 PST, Alex Christensen 		darin: review+
Details | Formatted Diff | Diff
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Alex Christensen 2015-12-16 18:14:13 PST 
Progress towards implementing downloads with NetworkSession
Comment 1 Alex Christensen 2015-12-16 18:14:54 PST 
Created attachment 267518 [details]
Patch
Comment 2 Darin Adler 2015-12-16 21:23:30 PST 
Comment on attachment 267518 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=267518&action=review

> Source/WebKit2/Shared/Downloads/Download.h:65
> +#if !USE(NETWORK_SESSION)
> +class ResourceHandle;
> +#endif

Seems unnecessary to put a conditional on a forward declaration. Also not great to have the #if in the middle like this. Normally we would put something in a separate paragraph. But I suggest just leaving this in unconditionally.
Comment 3 Alex Christensen 2015-12-16 23:10:00 PST 
(In reply to comment #2)
> Comment on attachment 267518 [details]
> Patch
> 
> View in context:
> https://bugs.webkit.org/attachment.cgi?id=267518&action=review
> 
> > Source/WebKit2/Shared/Downloads/Download.h:65
> > +#if !USE(NETWORK_SESSION)
> > +class ResourceHandle;
> > +#endif
> 
> Seems unnecessary to put a conditional on a forward declaration. Also not
> great to have the #if in the middle like this. Normally we would put
> something in a separate paragraph. But I suggest just leaving this in
> unconditionally.

I am trying to make sure to never use ResourceHandle in WebKit2 when using NetworkSession, but one ResourceHandle forward declaration doesn't hurt.

Committed to http://trac.webkit.org/changeset/194211