RESOLVED FIXED 152357
Simplify isOverlayScrollbar() logic 
https://bugs.webkit.org/show_bug.cgi?id=152357
Summary Simplify isOverlayScrollbar() logic
Simon Fraser (smfr)
Reported 2015-12-16 14:48:05 PST
Simplify isOverlayScrollbar() logic
Attachments
Patch (17.30 KB, patch)
2015-12-16 14:49 PST, Simon Fraser (smfr) 		bdakin: review+
DetailsFormatted DiffDiff
View All Add attachment proposed patch, testcase, etc.
Simon Fraser (smfr)
Comment 1 2015-12-16 14:49:52 PST
Created attachment 267493 [details] Patch
Simon Fraser (smfr)
Comment 2 2015-12-16 15:42:06 PST
https://trac.webkit.org/r194184
Darin Adler
Comment 3 2015-12-16 16:20:09 PST
Comment on attachment 267493 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=267493&action=review > Source/WebCore/platform/ScrollableArea.cpp:523 > + return IntSize( > + verticalScrollbar() ? verticalScrollbar()->occupiedWidth() : 0, > + horizontalScrollbar() ? horizontalScrollbar()->occupiedHeight() : 0); Here’s how I would write this: return { verticalScrollbar() ? verticalScrollbar()->occupiedWidth() : 0, horizontalScrollbar() ? horizontalScrollbar()->occupiedHeight() : 0 }; I like reducing the number of times we have to utter the type name IntSize, and I also like the formatting better with the braces.
Note You need to log in before you can comment on or make changes to this bug.