Bug 152352 - Web Inspector: Improve console.trace, make it more like console.assert and inline the message
Summary: Web Inspector: Improve console.trace, make it more like console.assert and in...
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: Web Inspector (show other bugs)
Version: WebKit Nightly Build
Hardware: All All
: P2 Normal
Assignee: Joseph Pecoraro
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2015-12-16 12:38 PST by Joseph Pecoraro
Modified: 2015-12-17 15:45 PST (History)
7 users (show)

See Also:

Attachments
[TEST] Test Case - Inspect this page (580 bytes, text/html)
2015-12-16 12:38 PST, Joseph Pecoraro 		no flags Details
[IMAGE] Before (204.98 KB, image/png)
2015-12-16 12:38 PST, Joseph Pecoraro 		no flags Details
[IMAGE] After (188.24 KB, image/png)
2015-12-16 12:39 PST, Joseph Pecoraro 		no flags Details
[PATCH] Proposed Fix (7.26 KB, patch)
2015-12-16 12:45 PST, Joseph Pecoraro 		timothy: review+
Details | Formatted Diff | Diff
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Joseph Pecoraro 2015-12-16 12:38:18 PST 
* SUMMARY
Improve console.trace, make it more like console.assert and inline the message.

Currently console.trace("Foo", arg) completely ignores `"Foo"` and `arg`. It should behave more like console.assert, and do things with the extra parameters.

* TEST (attached a standalone case)
console.trace();
console.trace("Message");
console.trace("Message", 1);
console.trace("Message", [1,2,3,4,5]);
console.trace("Message", {a:1,b:2,c:3,d:4,e:5,f:6});
console.trace("Message", 123, "two");

* STEPS TO REPRODUCE
1. Inspect test page
  => Trace messages should include message and extra parameters
2. Reload test page
  => Trace messages should include message and extra parameters and be slightly better with previews
Comment 1 Joseph Pecoraro 2015-12-16 12:38:35 PST 
Created attachment 267480 [details]
[TEST] Test Case - Inspect this page
Comment 2 Joseph Pecoraro 2015-12-16 12:38:55 PST 
Created attachment 267481 [details]
[IMAGE] Before
Comment 3 Joseph Pecoraro 2015-12-16 12:39:08 PST 
Created attachment 267482 [details]
[IMAGE] After
Comment 4 Joseph Pecoraro 2015-12-16 12:45:24 PST 
Created attachment 267483 [details]
[PATCH] Proposed Fix
Comment 5 Joseph Pecoraro 2015-12-16 13:00:14 PST 
Patch doesn't apply because of localized strings diff.
Comment 6 Joseph Pecoraro 2015-12-17 15:45:26 PST 
<http://trac.webkit.org/changeset/194243>