RESOLVED FIXED Bug 152351
Modern IDB: Have IDBServerOperations know whether they represent an open or delete request 
https://bugs.webkit.org/show_bug.cgi?id=152351
Summary Modern IDB: Have IDBServerOperations know whether they represent an open or d...
Brady Eidson
Reported 2015-12-16 12:12:11 PST
Modern IDB: Have IDBServerOperations know whether they represent an open or delete request
Attachments
Patch v1 (13.65 KB, patch)
2015-12-16 12:13 PST, Brady Eidson 		achristensen: review+
DetailsFormatted DiffDiff
View All Add attachment proposed patch, testcase, etc.
Brady Eidson
Comment 1 2015-12-16 12:13:54 PST
Created attachment 267479 [details] Patch v1
Alex Christensen
Comment 2 2015-12-16 12:24:39 PST
Comment on attachment 267479 [details] Patch v1 View in context: https://bugs.webkit.org/attachment.cgi?id=267479&action=review > Source/WebCore/Modules/indexeddb/client/IDBOpenDBRequestImpl.cpp:58 > + m_requestType = requestType; m_requestType(requestType) > Source/WebCore/Modules/indexeddb/server/UniqueIDBDatabase.cpp:254 > + auto operation = m_currentOperation; > + m_currentOperation = nullptr; WTF::move
Brady Eidson
Comment 3 2015-12-16 12:27:18 PST
(In reply to comment #2) > Comment on attachment 267479 [details] > Patch v1 > > View in context: > https://bugs.webkit.org/attachment.cgi?id=267479&action=review > > > Source/WebCore/Modules/indexeddb/client/IDBOpenDBRequestImpl.cpp:58 > > + m_requestType = requestType; > > m_requestType(requestType) m_requestType belongs to the super class, so the subclass can't initialize it directly. > > > Source/WebCore/Modules/indexeddb/server/UniqueIDBDatabase.cpp:254 > > + auto operation = m_currentOperation; > > + m_currentOperation = nullptr; > > WTF::move Will-do
Brady Eidson
Comment 4 2015-12-16 12:30:06 PST
http://trac.webkit.org/changeset/194169
Note You need to log in before you can comment on or make changes to this bug.