Bug 152330 – Web Inspector: Improve copy of console messages with multiple arguments - console.log(obj1, obj2)

• Status: RESOLVED
• Resolution: FIXED
• Component: Web Inspector

[Joseph Pecoraro]

* SUMMARY
Improve copy of console messages with multiple arguments - console.log(obj1, obj2)

* TEST
<script>
console.log("Message", 1, "string", /regex/);
console.log("Message", [1, 2], {x:10, y:20});
</script>

* STEPS TO REPRODUCE
1. Inspect test case
2. Reload (to ensure previews)
3. Select console messages
4. Copy
  => The actual data in the copy is missing!

BEFORE:

> [Log] Message (3) (copy.html, line 2)
> [Log] Message (2) (copy.html, line 3)

AFTER:

> [Log] Message (3) (copy.html, line 2)
> 1
> "string"
> /regex/
> 
> [Log] Message (2) (copy.html, line 3)
> [1, 2] (2)
> {x: 10, y: 20}

[Radar WebKit Bug Importer]

<rdar://problem/23916726>

[Joseph Pecoraro]

Another case: multiple arguments with call stack:

<script>
function foo() { console.error("Message", [1, 2], {x:10, y:20}); }
foo();
</script>


EXPECTED:

> [Error] Message (2)
> [1, 2] (2)
> {x: 10, y: 20}
> 	foo (copy.html:9)
> 	Global Code (copy.html:11)

Note the call stack coming after the arguments matches the UI here.

[Joseph Pecoraro]

Created attachment 267447 [details]
[PATCH] Proposed Fix

[WebKit Commit Bot]

Comment on attachment 267447 [details]
[PATCH] Proposed Fix

Clearing flags on attachment: 267447

Committed r194151: <http://trac.webkit.org/changeset/194151>

[WebKit Commit Bot]

All reviewed patches have been landed.  Closing bug.