152329 – Web Inspector: Improve copy of console message containing Array and Map output

Bug 152329 - Web Inspector: Improve copy of console message containing Array and Map output

Summary: Web Inspector: Improve copy of console message containing Array and Map output

Status:	RESOLVED FIXED

Alias:	None

Product:	WebKit
Classification:	Unclassified
Component:	Web Inspector (show other bugs)
Version:	WebKit Nightly Build
Hardware:	All All

Importance:	P2 Normal
Assignee:	Joseph Pecoraro

URL:
Keywords:	InRadar

Depends on:
Blocks:

Reported:	2015-12-16 00:19 PST by Joseph Pecoraro
Modified:	2015-12-16 09:42 PST (History)
CC List:	8 users (show)

See Also:

Attachments
[PATCH] Proposed Fix (5.26 KB, patch) 2015-12-16 00:21 PST, Joseph Pecoraro	no flags	Details \| Formatted Diff \| Diff
[IMAGE] Before - Used Margins (142.89 KB, image/png) 2015-12-16 00:21 PST, Joseph Pecoraro	no flags	Details
[IMAGE] After - Uses a Space (142.87 KB, image/png) 2015-12-16 00:22 PST, Joseph Pecoraro	no flags	Details
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.

Description Joseph Pecoraro 2015-12-16 00:19:44 PST

* SUMMARY
Improve copy of console message containing Array and Map output.

* STEPS TO REPRODUCE
1. Inspect about:blank
2. js> dir([1,2,3])
3. js> m = new Map; m.set("key", "value"); dir(m)
4. Expand both objects
5. Select both console messages and Copy
  => Poor formatting in copied text.

* BEFORE

> [Log] Array (3)
> 01
> 12
> 23
> Array Prototype
>
> [Log] Map (1)
> key"key"
> value"value"
> Map Prototype

* AFTER

> [Log] Array (3)
> 0 1
> 1 2
> 2 3
> Array Prototype
> 
> [Log] Map (1)
> key "key"
> value "value"
> Map Prototype

Comment 1 Radar WebKit Bug Importer 2015-12-16 00:19:58 PST

<rdar://problem/23916663>

Comment 2 Joseph Pecoraro 2015-12-16 00:21:30 PST

Created attachment 267444 [details]
[PATCH] Proposed Fix

Comment 3 Joseph Pecoraro 2015-12-16 00:21:47 PST

Created attachment 267445 [details]
[IMAGE] Before - Used Margins

Comment 4 Joseph Pecoraro 2015-12-16 00:22:01 PST

Created attachment 267446 [details]
[IMAGE] After - Uses a Space

Comment 5 WebKit Commit Bot 2015-12-16 09:42:38 PST

Comment on attachment 267444 [details]
[PATCH] Proposed Fix

Clearing flags on attachment: 267444

Committed r194150: <http://trac.webkit.org/changeset/194150>

Comment 6 WebKit Commit Bot 2015-12-16 09:42:42 PST

All reviewed patches have been landed.  Closing bug.