Bug 152323 - FontCascade cleanup: Remove ::drawSimpleText and ::drawComplexText.
Summary: FontCascade cleanup: Remove ::drawSimpleText and ::drawComplexText.
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: Layout and Rendering (show other bugs)
Version: WebKit Nightly Build
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: zalan
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2015-12-15 20:24 PST by zalan
Modified: 2015-12-15 22:28 PST (History)
3 users (show)

See Also:


Attachments
Patch (10.19 KB, patch)
2015-12-15 20:30 PST, zalan
no flags Details | Formatted Diff | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description zalan 2015-12-15 20:24:18 PST
platform code has platform independent logic.
Comment 1 zalan 2015-12-15 20:30:22 PST
Created attachment 267428 [details]
Patch
Comment 2 Myles C. Maxfield 2015-12-15 21:02:32 PST
Comment on attachment 267428 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=267428&action=review

r=me !!!!!

> Source/WebCore/platform/graphics/FontCascade.cpp:309
> +float FontCascade::glyphBufferForTextRun(CodePath codePathToUse, const TextRun& run, int from, int to, GlyphBuffer& glyphBuffer) const

This doesn't need to be a class member function. It can just be static (not in any header).
Comment 3 zalan 2015-12-15 21:07:48 PST
(In reply to comment #2)
> Comment on attachment 267428 [details]
> Patch
> 
> View in context:
> https://bugs.webkit.org/attachment.cgi?id=267428&action=review
> 
> r=me !!!!!
> 
> > Source/WebCore/platform/graphics/FontCascade.cpp:309
> > +float FontCascade::glyphBufferForTextRun(CodePath codePathToUse, const TextRun& run, int from, int to, GlyphBuffer& glyphBuffer) const
> 
> This doesn't need to be a class member function. It can just be static (not
> in any header).
I should have mentioned that this patch is also in preparation for adding glyph caching. (which will require this to either be a member function or pass in the fontcascade object. -and i'd rather do the former.)
Comment 4 WebKit Commit Bot 2015-12-15 22:28:40 PST
Comment on attachment 267428 [details]
Patch

Clearing flags on attachment: 267428

Committed r194132: <http://trac.webkit.org/changeset/194132>
Comment 5 WebKit Commit Bot 2015-12-15 22:28:43 PST
All reviewed patches have been landed.  Closing bug.