RESOLVED FIXED 152323
FontCascade cleanup: Remove ::drawSimpleText and ::drawComplexText.
https://bugs.webkit.org/show_bug.cgi?id=152323
Summary FontCascade cleanup: Remove ::drawSimpleText and ::drawComplexText.
zalan
Reported 2015-12-15 20:24:18 PST
platform code has platform independent logic.
Attachments
Patch (10.19 KB, patch)
2015-12-15 20:30 PST, zalan
no flags
zalan
Comment 1 2015-12-15 20:30:22 PST
Myles C. Maxfield
Comment 2 2015-12-15 21:02:32 PST
Comment on attachment 267428 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=267428&action=review r=me !!!!! > Source/WebCore/platform/graphics/FontCascade.cpp:309 > +float FontCascade::glyphBufferForTextRun(CodePath codePathToUse, const TextRun& run, int from, int to, GlyphBuffer& glyphBuffer) const This doesn't need to be a class member function. It can just be static (not in any header).
zalan
Comment 3 2015-12-15 21:07:48 PST
(In reply to comment #2) > Comment on attachment 267428 [details] > Patch > > View in context: > https://bugs.webkit.org/attachment.cgi?id=267428&action=review > > r=me !!!!! > > > Source/WebCore/platform/graphics/FontCascade.cpp:309 > > +float FontCascade::glyphBufferForTextRun(CodePath codePathToUse, const TextRun& run, int from, int to, GlyphBuffer& glyphBuffer) const > > This doesn't need to be a class member function. It can just be static (not > in any header). I should have mentioned that this patch is also in preparation for adding glyph caching. (which will require this to either be a member function or pass in the fontcascade object. -and i'd rather do the former.)
WebKit Commit Bot
Comment 4 2015-12-15 22:28:40 PST
Comment on attachment 267428 [details] Patch Clearing flags on attachment: 267428 Committed r194132: <http://trac.webkit.org/changeset/194132>
WebKit Commit Bot
Comment 5 2015-12-15 22:28:43 PST
All reviewed patches have been landed. Closing bug.
Note You need to log in before you can comment on or make changes to this bug.