platform code has platform independent logic.
Created attachment 267428 [details] Patch
Comment on attachment 267428 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=267428&action=review r=me !!!!! > Source/WebCore/platform/graphics/FontCascade.cpp:309 > +float FontCascade::glyphBufferForTextRun(CodePath codePathToUse, const TextRun& run, int from, int to, GlyphBuffer& glyphBuffer) const This doesn't need to be a class member function. It can just be static (not in any header).
(In reply to comment #2) > Comment on attachment 267428 [details] > Patch > > View in context: > https://bugs.webkit.org/attachment.cgi?id=267428&action=review > > r=me !!!!! > > > Source/WebCore/platform/graphics/FontCascade.cpp:309 > > +float FontCascade::glyphBufferForTextRun(CodePath codePathToUse, const TextRun& run, int from, int to, GlyphBuffer& glyphBuffer) const > > This doesn't need to be a class member function. It can just be static (not > in any header). I should have mentioned that this patch is also in preparation for adding glyph caching. (which will require this to either be a member function or pass in the fontcascade object. -and i'd rather do the former.)
Comment on attachment 267428 [details] Patch Clearing flags on attachment: 267428 Committed r194132: <http://trac.webkit.org/changeset/194132>
All reviewed patches have been landed. Closing bug.