Bug 152322 – [Cocoa] lang=zh-HK doesn't cause a Hong Kong-specific font to be used

• Status: RESOLVED
• Resolution: DUPLICATE
• Component: New Bugs

[Myles C. Maxfield]

[Cocoa] lang=zh-HK doesn't cause a Hong Kong-specific font to be used

[Myles C. Maxfield]

Created attachment 267425 [details]
Patch

[WebKit Commit Bot]

Attachment 267425 [details] did not pass style-queue:


ERROR: Source/WebCore/platform/text/LocaleToScriptMapping.h:40:  USCRIPT_HONG_KONG is incorrectly named. Don't use underscores in your identifier names.  [readability/naming/underscores] [4]
Total errors found: 1 in 7 files


If any of these errors are false positives, please file a bug against check-webkit-style.

[Myles C. Maxfield]

<rdar://problem/22391755>

[Myles C. Maxfield]

Created attachment 267426 [details]
Patch

[WebKit Commit Bot]

Attachment 267426 [details] did not pass style-queue:


ERROR: Source/WebCore/platform/text/LocaleToScriptMapping.h:40:  USCRIPT_HONG_KONG is incorrectly named. Don't use underscores in your identifier names.  [readability/naming/underscores] [4]
Total errors found: 1 in 7 files


If any of these errors are false positives, please file a bug against check-webkit-style.

[Build Bot]

Comment on attachment 267426 [details]
Patch

Attachment 267426 [details] did not pass mac-ews (mac):
Output: http://webkit-queues.webkit.org/results/565175

New failing tests:
fast/text/han-generic-font-families.html

[Build Bot]

Created attachment 267429 [details]
Archive of layout-test-results from ews103 for mac-yosemite

The attached test failures were seen while running run-webkit-tests on the mac-ews.
Bot: ews103  Port: mac-yosemite  Platform: Mac OS X 10.10.5

[Build Bot]

Comment on attachment 267426 [details]
Patch

Attachment 267426 [details] did not pass mac-wk2-ews (mac-wk2):
Output: http://webkit-queues.webkit.org/results/565178

New failing tests:
fast/text/han-generic-font-families.html

[Build Bot]

Created attachment 267431 [details]
Archive of layout-test-results from ews105 for mac-yosemite-wk2

The attached test failures were seen while running run-webkit-tests on the mac-wk2-ews.
Bot: ews105  Port: mac-yosemite-wk2  Platform: Mac OS X 10.10.5

[Build Bot]

Comment on attachment 267426 [details]
Patch

Attachment 267426 [details] did not pass mac-debug-ews (mac):
Output: http://webkit-queues.webkit.org/results/565170

New failing tests:
fast/text/han-generic-font-families.html

[Build Bot]

Created attachment 267432 [details]
Archive of layout-test-results from ews113 for mac-yosemite

The attached test failures were seen while running run-webkit-tests on the mac-debug-ews.
Bot: ews113  Port: mac-yosemite  Platform: Mac OS X 10.10.5

[Myles C. Maxfield]

Created attachment 267433 [details]
Patch

[WebKit Commit Bot]

Attachment 267433 [details] did not pass style-queue:


ERROR: Source/WebCore/platform/text/LocaleToScriptMapping.h:40:  USCRIPT_HONG_KONG is incorrectly named. Don't use underscores in your identifier names.  [readability/naming/underscores] [4]
Total errors found: 1 in 12 files


If any of these errors are false positives, please file a bug against check-webkit-style.

[Darin Adler]

Comment on attachment 267433 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=267433&action=review

> Source/WebCore/platform/text/LocaleToScriptMapping.h:40
> +// No script for Hong Kong, but generic font selection must receive a unique identifier
> +const UScriptCode USCRIPT_HONG_KONG = static_cast<UScriptCode>(USCRIPT_CODE_LIMIT + 1);

I think it’s slightly peculiar for us to use the same formatting that ICU itself uses for our non-ICU constant. I understand that it’s safe for us to define our own value for UScriptCode as long as we don’t try to pass it back to ICU, but I think it would be slightly nicer to use a constant name that makes it clearer that it’s not actually a real ICU UScriptCode.

[Darin Adler]

Comment on attachment 267433 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=267433&action=review

>> Source/WebCore/platform/text/LocaleToScriptMapping.h:40
>> +const UScriptCode USCRIPT_HONG_KONG = static_cast<UScriptCode>(USCRIPT_CODE_LIMIT + 1);
> 
> I think it’s slightly peculiar for us to use the same formatting that ICU itself uses for our non-ICU constant. I understand that it’s safe for us to define our own value for UScriptCode as long as we don’t try to pass it back to ICU, but I think it would be slightly nicer to use a constant name that makes it clearer that it’s not actually a real ICU UScriptCode.

Given how we handle ICU headers, I think it’s risky to use USCRIPT_CODE_LIMIT for this. It’s possible that the actual ICU library will be newer than the headers, and so a script code will be higher than what the header thinks the limit is; that might even cause problem in practice. I suggest we consider the possibility something safer like use a maximum value of some sort, or even find a way to defining our own type that contains both a UScriptCode and additional information so we can track that this is a Hong Kong script without any non-standard UScriptCode tricks.

[Myles C. Maxfield]

This was fixed by r241288

[Myles C. Maxfield]

*** This bug has been marked as a duplicate of bug 187723 ***