Bug 152314 - REGRESSION (r192375): DumpRenderTree.app exits immediately with no error
Summary: REGRESSION (r192375): DumpRenderTree.app exits immediately with no error
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: Tools / Tests (show other bugs)
Version: WebKit Local Build
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: David Kilzer (:ddkilzer)
URL:
Keywords: InRadar
Depends on:
Blocks:
 
Reported: 2015-12-15 13:58 PST by David Kilzer (:ddkilzer)
Modified: 2015-12-15 14:34 PST (History)
7 users (show)

See Also:


Attachments
Patch v1 (11.89 KB, patch)
2015-12-15 14:00 PST, David Kilzer (:ddkilzer)
dbates: review+
dbates: commit-queue-
Details | Formatted Diff | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description David Kilzer (:ddkilzer) 2015-12-15 13:58:23 PST
The change to DumpRenderTreeMain.mm in r192375 caused the iOS code path to exit immediately when calling main() as all apps are wont to do.  Unfortunately, DumpRenderTreeMain.mm was used for both DumpRenderTree command-line binary and DumpRenderTree.app, which meant that the app would exit immediately with no error code when run!

The workaround is to introduce a separate source file called DumpRenderTreeAppMain.mm, similar to what WebKitTestRunner already does.
Comment 1 David Kilzer (:ddkilzer) 2015-12-15 14:00:46 PST
Created attachment 267392 [details]
Patch v1
Comment 2 Daniel Bates 2015-12-15 14:06:18 PST
Comment on attachment 267392 [details]
Patch v1

View in context: https://bugs.webkit.org/attachment.cgi?id=267392&action=review

> Tools/ChangeLog:10
> +        The change to DumpRenderTreeMain.mm in r192375 caused the iOS
> +        code path to exit immediately when calling main() as all apps
> +        are wont to do.  Unfortunately, DumpRenderTreeMain.mm was used

The first sentence does not read well. In particular, the phrase "as all apps are wont to do" does not read well.
Comment 3 David Kilzer (:ddkilzer) 2015-12-15 14:11:11 PST
Committed r194115: <http://trac.webkit.org/changeset/194115>
Comment 4 David Kilzer (:ddkilzer) 2015-12-15 14:34:50 PST
<rdar://problem/23546265>