Bug 152288 - FTL B3 should account for localsOffset
Summary: FTL B3 should account for localsOffset
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: JavaScriptCore (show other bugs)
Version: WebKit Nightly Build
Hardware: All All
: P2 Normal
Assignee: Filip Pizlo
URL:
Keywords:
Depends on:
Blocks: 151808
  Show dependency treegraph
 
Reported: 2015-12-14 19:09 PST by Filip Pizlo
Modified: 2015-12-14 20:54 PST (History)
12 users (show)

See Also:


Attachments
the patch (18.50 KB, patch)
2015-12-14 19:18 PST, Filip Pizlo
sbarati: review+
Details | Formatted Diff | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Filip Pizlo 2015-12-14 19:09:16 PST
Patch forthcoming.
Comment 1 Filip Pizlo 2015-12-14 19:18:48 PST
Created attachment 267335 [details]
the patch
Comment 2 Saam Barati 2015-12-14 19:27:57 PST
Comment on attachment 267335 [details]
the patch

View in context: https://bugs.webkit.org/attachment.cgi?id=267335&action=review

r=me

> Source/JavaScriptCore/ChangeLog:30
> +            ValueFromBlock fooValue = things;

This should be "LValue fooValue = things;"
Comment 3 Filip Pizlo 2015-12-14 19:29:17 PST
(In reply to comment #2)
> Comment on attachment 267335 [details]
> the patch
> 
> View in context:
> https://bugs.webkit.org/attachment.cgi?id=267335&action=review
> 
> r=me
> 
> > Source/JavaScriptCore/ChangeLog:30
> > +            ValueFromBlock fooValue = things;
> 
> This should be "LValue fooValue = things;"

Yup, fixed.
Comment 4 Filip Pizlo 2015-12-14 20:54:17 PST
Landed in http://trac.webkit.org/changeset/194092