Bug 152280 – Web Inspector: Stack traces in console incorrectly show "(anonymous function)" for global code

• Status: RESOLVED
• Resolution: FIXED
• Component: Web Inspector

[Joseph Pecoraro]

* SUMMARY
Stack traces in console incorrectly show "(anonymous function)" for global code.

* TEST
<script>
function foo() { bar(); }
function bar() { console.trace(); }
foo();
</script>

* STEPS TO REPRODUCE
1. Open test case
2. Show Console in inspector
  => trace output lists "(anonymous function)" at global code level. This is wrong / incorrect.

[Radar WebKit Bug Importer]

<rdar://problem/23891615>

[Joseph Pecoraro]

Created attachment 267324 [details]
[PATCH] Proposed Fix

[Joseph Pecoraro]

Created attachment 267325 [details]
[IMAGE] Before

[Joseph Pecoraro]

Created attachment 267327 [details]
[IMAGE] After

[Blaze Burg]

Comment on attachment 267324 [details]
[PATCH] Proposed Fix

View in context: https://bugs.webkit.org/attachment.cgi?id=267324&action=review

r=me

I will note for posterity that I don't like the name "program" for a top-level evaluation. I prefer (evaluation), (module evaluation), (global evaluation), etc. If we had a fake call frame for the vm entry method (rAF, parsing, events, etc) then we could use that as the "program" call frame in the UI.

> Source/WebInspectorUI/UserInterface/Models/CallFrame.js:135
> +        var functionName = payload.functionName;

Nit: let

[WebKit Commit Bot]

Comment on attachment 267324 [details]
[PATCH] Proposed Fix

Clearing flags on attachment: 267324

Committed r194083: <http://trac.webkit.org/changeset/194083>

[WebKit Commit Bot]

All reviewed patches have been landed.  Closing bug.