Bug 152274 - Web Inspector: Convert Sidebar classes to use View
Summary: Web Inspector: Convert Sidebar classes to use View
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: Web Inspector (show other bugs)
Version: WebKit Nightly Build
Hardware: All All
: P2 Normal
Assignee: Matt Baker
URL:
Keywords: InRadar
Depends on:
Blocks: 152269
  Show dependency treegraph
 
Reported: 2015-12-14 14:30 PST by Matt Baker
Modified: 2015-12-15 14:34 PST (History)
8 users (show)

See Also:


Attachments
[Patch] Proposed Fix (32.99 KB, patch)
2015-12-14 22:21 PST, Matt Baker
no flags Details | Formatted Diff | Diff
[Patch] Proposed Fix (33.07 KB, patch)
2015-12-15 13:44 PST, Matt Baker
no flags Details | Formatted Diff | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Matt Baker 2015-12-14 14:30:23 PST
* SUMMARY
Convert Sidebar classes to use View.

SidebarPanel should create a 'contentView' subview with a public getter, for appending DetailsSections. This will complete some work originally slated for https://bugs.webkit.org/show_bug.cgi?id=150982.
Comment 1 Radar WebKit Bug Importer 2015-12-14 14:31:02 PST
<rdar://problem/23889272>
Comment 2 Matt Baker 2015-12-14 22:21:19 PST
Created attachment 267349 [details]
[Patch] Proposed Fix
Comment 3 BJ Burg 2015-12-15 09:15:20 PST
Comment on attachment 267349 [details]
[Patch] Proposed Fix

View in context: https://bugs.webkit.org/attachment.cgi?id=267349&action=review

r=me

A little surprised we don't need to call needsLayout anywhere. I suppose the panels just add and remove sections, so the sections should become dirty, not the panel.

> Source/WebInspectorUI/UserInterface/Views/ProbeDetailsSidebarPanel.js:61
>              var shownSection = this._probeSetSections.get(probeSet);

Nit: let

> Source/WebInspectorUI/UserInterface/Views/StyleDetailsPanel.js:-49
> -    {

Comment for ChangeLog: "defer to View.element getter." It says no longer needed, but the getter is still used (just implemented elsewhere).
Comment 4 Matt Baker 2015-12-15 13:44:09 PST
Created attachment 267391 [details]
[Patch] Proposed Fix
Comment 5 WebKit Commit Bot 2015-12-15 14:34:21 PST
Comment on attachment 267391 [details]
[Patch] Proposed Fix

Clearing flags on attachment: 267391

Committed r194116: <http://trac.webkit.org/changeset/194116>
Comment 6 WebKit Commit Bot 2015-12-15 14:34:25 PST
All reviewed patches have been landed.  Closing bug.