Bug 152274 – Web Inspector: Convert Sidebar classes to use View

• Status: RESOLVED
• Resolution: FIXED
• Component: Web Inspector

[Matt Baker]

* SUMMARY
Convert Sidebar classes to use View.

SidebarPanel should create a 'contentView' subview with a public getter, for appending DetailsSections. This will complete some work originally slated for https://bugs.webkit.org/show_bug.cgi?id=150982.

[Radar WebKit Bug Importer]

<rdar://problem/23889272>

[Matt Baker]

Created attachment 267349 [details]
[Patch] Proposed Fix

[Blaze Burg]

Comment on attachment 267349 [details]
[Patch] Proposed Fix

View in context: https://bugs.webkit.org/attachment.cgi?id=267349&action=review

r=me

A little surprised we don't need to call needsLayout anywhere. I suppose the panels just add and remove sections, so the sections should become dirty, not the panel.

> Source/WebInspectorUI/UserInterface/Views/ProbeDetailsSidebarPanel.js:61
>              var shownSection = this._probeSetSections.get(probeSet);

Nit: let

> Source/WebInspectorUI/UserInterface/Views/StyleDetailsPanel.js:-49
> -    {

Comment for ChangeLog: "defer to View.element getter." It says no longer needed, but the getter is still used (just implemented elsewhere).

[Matt Baker]

Created attachment 267391 [details]
[Patch] Proposed Fix

[WebKit Commit Bot]

Comment on attachment 267391 [details]
[Patch] Proposed Fix

Clearing flags on attachment: 267391

Committed r194116: <http://trac.webkit.org/changeset/194116>

[WebKit Commit Bot]

All reviewed patches have been landed.  Closing bug.