Bug 152265 – Guard code that uses class LayerTreeHost with USE(COORDINATED_GRAPHICS) or USE(TEXTURE_MAPPER)

• Status: RESOLVED
• Resolution: FIXED
• Component: WebKit2

[Daniel Bates]

We do not use class LayerTreeHost on Mac or iOS. We should not compile code that makes use of LayerTreeHost on these platforms.

[Daniel Bates]

Created attachment 267316 [details]
Patch

[Csaba Osztrogonác]

(In reply to comment #1)
> Created attachment 267316 [details]
> Patch

Adding include "LayerTreeContext.h" to WebPage.h fixes (at least) the EFL build.
( But I don't know if it is the right fix or not. )

[Michael Catanzaro]

Before committing, please check with Darin or Carlos Garcia -- I think they prefer to add include guards around the entire header file, rather than around the #include statement, right? (Or do I have this backwards?)

[Darin Adler]

Comment on attachment 267316 [details]
Patch

Typically we guard entire header files for clarity and simplicity. It’s also OK to guard include statements; that can speed up builds and sometimes makes the .cpp files slightly easier to understand. This should be covered in some project style guide document; if it’s not I’m surprised.

[Gwang Yoon Hwang]

(In reply to comment #2)
> (In reply to comment #1)
> > Created attachment 267316 [details]
> > Patch
> 
> Adding include "LayerTreeContext.h" to WebPage.h fixes (at least) the EFL
> build.
> ( But I don't know if it is the right fix or not. )

LayerTreeContext.h should be included in the WebPage.h regardless of this modification. It was included by LayerTreeHost indirectly.

I hope this patch adds LayerTreeContext.h to the WebPage.h to remove red buttons in ews.

[Daniel Bates]

Created attachment 267376 [details]
Patch

(Patch for EWS)

Updated patch based on the feedback from Csaba Osztrogonác, Michael Catanzaro, Darin Adler, and Gwang Yoon Hwang.

[Daniel Bates]

Created attachment 267377 [details]
Patch

[Daniel Bates]

Committed r194108: <http://trac.webkit.org/changeset/194108>

[Michael Catanzaro]

(In reply to comment #4) 
> Typically we guard entire header files for clarity and simplicity. It’s also
> OK to guard include statements; that can speed up builds and sometimes makes
> the .cpp files slightly easier to understand. This should be covered in some
> project style guide document; if it’s not I’m surprised.

I don't believe it's discussed on https://webkit.org/code-style-guidelines