Bug 152251 - [css-align][css-grid] Overflow alignment value 'true' renamed to 'unsafe'
Summary: [css-align][css-grid] Overflow alignment value 'true' renamed to 'unsafe'
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: CSS (show other bugs)
Version: WebKit Nightly Build
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Javier Fernandez
URL:
Keywords: BlinkMergeCandidate
Depends on:
Blocks: 152249
  Show dependency tree / graph
 
Reported: 2015-12-14 06:14 PST by Javier Fernandez
Modified: 2015-12-15 04:12 PST (History)
9 users (show)

See Also:

Attachments
Patch (104.81 KB, patch)
2015-12-14 06:33 PST, Javier Fernandez 		no flags Details | Formatted Diff | Diff
Archive of layout-test-results from ews101 for mac-yosemite (1.15 MB, application/zip)
2015-12-14 07:30 PST, Build Bot 		no flags Details
Archive of layout-test-results from ews106 for mac-yosemite-wk2 (1.21 MB, application/zip)
2015-12-14 07:35 PST, Build Bot 		no flags Details
Archive of layout-test-results from ews115 for mac-yosemite (794.43 KB, application/zip)
2015-12-14 07:42 PST, Build Bot 		no flags Details
Patch (104.07 KB, patch)
2015-12-14 12:41 PST, Javier Fernandez 		no flags Details | Formatted Diff | Diff
Show Obsolete (1) View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Javier Fernandez 2015-12-14 06:14:34 PST 
The CSS Box Alignment spec changed the syntax of overflow alignment so that the value 'true' has been renamed to 'unsafe'.

There is no change in the behavior of the old keyword, just a syntax change, which affects just parsing and computed style logic.

diff: https://hg.csswg.org/drafts/rev/f34a2a8b8177
Comment 1 Javier Fernandez 2015-12-14 06:16:35 PST 
This bug would need merging the patch for the blink's issue 1497403002.
Comment 2 Javier Fernandez 2015-12-14 06:33:42 PST 
Created attachment 267291 [details]
Patch
Comment 3 Build Bot 2015-12-14 07:30:45 PST 
Comment on attachment 267291 [details]
Patch

Attachment 267291 [details] did not pass mac-ews (mac):
Output: http://webkit-queues.webkit.org/results/558252

New failing tests:
fast/css/parse-justify-self.html
fast/css/parse-justify-items.html
Comment 4 Build Bot 2015-12-14 07:30:48 PST 
Created attachment 267292 [details]
Archive of layout-test-results from ews101 for mac-yosemite

The attached test failures were seen while running run-webkit-tests on the mac-ews.
Bot: ews101  Port: mac-yosemite  Platform: Mac OS X 10.10.5
Comment 5 Build Bot 2015-12-14 07:35:09 PST 
Comment on attachment 267291 [details]
Patch

Attachment 267291 [details] did not pass mac-wk2-ews (mac-wk2):
Output: http://webkit-queues.webkit.org/results/558257

New failing tests:
fast/css/parse-justify-self.html
fast/css/parse-justify-items.html
Comment 6 Build Bot 2015-12-14 07:35:12 PST 
Created attachment 267293 [details]
Archive of layout-test-results from ews106 for mac-yosemite-wk2

The attached test failures were seen while running run-webkit-tests on the mac-wk2-ews.
Bot: ews106  Port: mac-yosemite-wk2  Platform: Mac OS X 10.10.5
Comment 7 Build Bot 2015-12-14 07:42:32 PST 
Comment on attachment 267291 [details]
Patch

Attachment 267291 [details] did not pass mac-debug-ews (mac):
Output: http://webkit-queues.webkit.org/results/558247

New failing tests:
fast/css/parse-justify-self.html
fast/css/parse-justify-items.html
Comment 8 Build Bot 2015-12-14 07:42:36 PST 
Created attachment 267294 [details]
Archive of layout-test-results from ews115 for mac-yosemite

The attached test failures were seen while running run-webkit-tests on the mac-debug-ews.
Bot: ews115  Port: mac-yosemite  Platform: Mac OS X 10.10.5
Comment 9 Javier Fernandez 2015-12-14 12:41:03 PST 
Created attachment 267315 [details]
Patch
Comment 10 WebKit Commit Bot 2015-12-15 04:12:22 PST 
Comment on attachment 267315 [details]
Patch

Clearing flags on attachment: 267315

Committed r194104: <http://trac.webkit.org/changeset/194104>
Comment 11 WebKit Commit Bot 2015-12-15 04:12:28 PST 
All reviewed patches have been landed.  Closing bug.