Bug 152212 - Web Inspector: "Selected Element" should use sans-serif font, not monospace
Summary: Web Inspector: "Selected Element" should use sans-serif font, not monospace
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: Web Inspector (show other bugs)
Version: WebKit Local Build
Hardware: All All
: P2 Normal
Assignee: Nikita Vasilyev
URL:
Keywords: InRadar
Depends on:
Blocks:
 
Reported: 2015-12-11 22:08 PST by Nikita Vasilyev
Modified: 2015-12-12 09:32 PST (History)
8 users (show)

See Also:

Attachments
[Animated GIF] Actual/expected (8.25 KB, image/gif)
2015-12-11 22:08 PST, Nikita Vasilyev 		no flags Details
Patch (1.28 KB, patch)
2015-12-11 22:10 PST, Nikita Vasilyev 		no flags Details | Formatted Diff | Diff
[Animated GIF] Actual/expected (5.94 KB, image/gif)
2015-12-12 00:39 PST, Nikita Vasilyev 		no flags Details
Patch (1.37 KB, patch)
2015-12-12 00:41 PST, Nikita Vasilyev 		no flags Details | Formatted Diff | Diff
Show Obsolete (2) View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Nikita Vasilyev 2015-12-11 22:08:48 PST 
Created attachment 267220 [details]
[Animated GIF] Actual/expected

"Selected Element" isn't code and isn't editable. It shouldn't be monospace.
Comment 1 Radar WebKit Bug Importer 2015-12-11 22:09:04 PST 
<rdar://problem/23870644>
Comment 2 Nikita Vasilyev 2015-12-11 22:10:10 PST 
Created attachment 267221 [details]
Patch
Comment 3 Joseph Pecoraro 2015-12-12 00:16:12 PST 
Err, in the gif the sans-serif version looks too fat to me. The blue background grew up and down, and it looks unbalanced around the text.
Comment 4 Nikita Vasilyev 2015-12-12 00:39:26 PST 
Created attachment 267229 [details]
[Animated GIF] Actual/expected

(In reply to comment #3)
> Err, in the gif the sans-serif version looks too fat to me. The blue
> background grew up and down, and it looks unbalanced around the text.

Now?
Comment 5 Nikita Vasilyev 2015-12-12 00:41:04 PST 
Created attachment 267230 [details]
Patch
Comment 6 Timothy Hatcher 2015-12-12 08:46:13 PST 
New version looks better.
Comment 7 WebKit Commit Bot 2015-12-12 09:32:39 PST 
Comment on attachment 267230 [details]
Patch

Clearing flags on attachment: 267230

Committed r194008: <http://trac.webkit.org/changeset/194008>
Comment 8 WebKit Commit Bot 2015-12-12 09:32:43 PST 
All reviewed patches have been landed.  Closing bug.