Bug 152208 - [JSC] Add lowering for B3's Store8 opcode
Summary: [JSC] Add lowering for B3's Store8 opcode
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: New Bugs (show other bugs)
Version: WebKit Nightly Build
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Benjamin Poulain
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2015-12-11 19:56 PST by Benjamin Poulain
Modified: 2015-12-12 15:05 PST (History)
5 users (show)

See Also:

Attachments
Patch (8.94 KB, patch)
2015-12-11 19:57 PST, Benjamin Poulain 		no flags Details | Formatted Diff | Diff
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Benjamin Poulain 2015-12-11 19:56:35 PST 
[JSC] Add lowering for B3's Store8 opcode
Comment 1 Benjamin Poulain 2015-12-11 19:57:17 PST 
Created attachment 267214 [details]
Patch
Comment 2 WebKit Commit Bot 2015-12-11 20:27:09 PST 
Attachment 267214 [details] did not pass style-queue:


ERROR: Source/JavaScriptCore/b3/testb3.cpp:3391:  Consider using CHECK_EQ instead of CHECK(a == b)  [readability/check] [2]
ERROR: Source/JavaScriptCore/b3/testb3.cpp:3392:  Consider using CHECK_EQ instead of CHECK(a == b)  [readability/check] [2]
ERROR: Source/JavaScriptCore/b3/testb3.cpp:3412:  Consider using CHECK_EQ instead of CHECK(a == b)  [readability/check] [2]
ERROR: Source/JavaScriptCore/b3/testb3.cpp:3413:  Consider using CHECK_EQ instead of CHECK(a == b)  [readability/check] [2]
ERROR: Source/JavaScriptCore/b3/testb3.cpp:3430:  Consider using CHECK_EQ instead of CHECK(a == b)  [readability/check] [2]
ERROR: Source/JavaScriptCore/b3/testb3.cpp:3431:  Consider using CHECK_EQ instead of CHECK(a == b)  [readability/check] [2]
ERROR: Source/JavaScriptCore/b3/testb3.cpp:3450:  Consider using CHECK_EQ instead of CHECK(a == b)  [readability/check] [2]
ERROR: Source/JavaScriptCore/b3/testb3.cpp:3451:  Consider using CHECK_EQ instead of CHECK(a == b)  [readability/check] [2]
ERROR: Source/JavaScriptCore/b3/testb3.cpp:3488:  Place brace on its own line for function definitions.  [whitespace/braces] [4]
ERROR: Source/JavaScriptCore/b3/testb3.cpp:3502:  Consider using CHECK_EQ instead of CHECK(a == b)  [readability/check] [2]
Total errors found: 10 in 4 files


If any of these errors are false positives, please file a bug against check-webkit-style.
Comment 3 Geoffrey Garen 2015-12-12 13:48:48 PST 
Comment on attachment 267214 [details]
Patch

r=me
Comment 4 WebKit Commit Bot 2015-12-12 15:05:20 PST 
Comment on attachment 267214 [details]
Patch

Clearing flags on attachment: 267214

Committed r194011: <http://trac.webkit.org/changeset/194011>
Comment 5 WebKit Commit Bot 2015-12-12 15:05:24 PST 
All reviewed patches have been landed.  Closing bug.