RESOLVED FIXED 152208
[JSC] Add lowering for B3's Store8 opcode 
https://bugs.webkit.org/show_bug.cgi?id=152208
Summary [JSC] Add lowering for B3's Store8 opcode
Benjamin Poulain
Reported 2015-12-11 19:56:35 PST
[JSC] Add lowering for B3's Store8 opcode
Attachments
Patch (8.94 KB, patch)
2015-12-11 19:57 PST, Benjamin Poulain 		no flags
DetailsFormatted DiffDiff
View All Add attachment proposed patch, testcase, etc.
Benjamin Poulain
Comment 1 2015-12-11 19:57:17 PST
Created attachment 267214 [details] Patch
WebKit Commit Bot
Comment 2 2015-12-11 20:27:09 PST
Attachment 267214 [details] did not pass style-queue: ERROR: Source/JavaScriptCore/b3/testb3.cpp:3391: Consider using CHECK_EQ instead of CHECK(a == b) [readability/check] [2] ERROR: Source/JavaScriptCore/b3/testb3.cpp:3392: Consider using CHECK_EQ instead of CHECK(a == b) [readability/check] [2] ERROR: Source/JavaScriptCore/b3/testb3.cpp:3412: Consider using CHECK_EQ instead of CHECK(a == b) [readability/check] [2] ERROR: Source/JavaScriptCore/b3/testb3.cpp:3413: Consider using CHECK_EQ instead of CHECK(a == b) [readability/check] [2] ERROR: Source/JavaScriptCore/b3/testb3.cpp:3430: Consider using CHECK_EQ instead of CHECK(a == b) [readability/check] [2] ERROR: Source/JavaScriptCore/b3/testb3.cpp:3431: Consider using CHECK_EQ instead of CHECK(a == b) [readability/check] [2] ERROR: Source/JavaScriptCore/b3/testb3.cpp:3450: Consider using CHECK_EQ instead of CHECK(a == b) [readability/check] [2] ERROR: Source/JavaScriptCore/b3/testb3.cpp:3451: Consider using CHECK_EQ instead of CHECK(a == b) [readability/check] [2] ERROR: Source/JavaScriptCore/b3/testb3.cpp:3488: Place brace on its own line for function definitions. [whitespace/braces] [4] ERROR: Source/JavaScriptCore/b3/testb3.cpp:3502: Consider using CHECK_EQ instead of CHECK(a == b) [readability/check] [2] Total errors found: 10 in 4 files If any of these errors are false positives, please file a bug against check-webkit-style.
Geoffrey Garen
Comment 3 2015-12-12 13:48:48 PST
Comment on attachment 267214 [details] Patch r=me
WebKit Commit Bot
Comment 4 2015-12-12 15:05:20 PST
Comment on attachment 267214 [details] Patch Clearing flags on attachment: 267214 Committed r194011: <http://trac.webkit.org/changeset/194011>
WebKit Commit Bot
Comment 5 2015-12-12 15:05:24 PST
All reviewed patches have been landed. Closing bug.
Note You need to log in before you can comment on or make changes to this bug.