Bug 152207 - Use existing code for redirects when using NETWORK_SESSION
Summary: Use existing code for redirects when using NETWORK_SESSION
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: New Bugs (show other bugs)
Version: WebKit Nightly Build
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Alex Christensen
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2015-12-11 18:47 PST by Alex Christensen
Modified: 2015-12-14 13:54 PST (History)
0 users

See Also:

Attachments
Patch (4.51 KB, patch)
2015-12-11 18:47 PST, Alex Christensen 		no flags Details | Formatted Diff | Diff
Patch (4.65 KB, patch)
2015-12-12 17:17 PST, Alex Christensen 		darin: review+
Details | Formatted Diff | Diff
Show Obsolete (1) View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Alex Christensen 2015-12-11 18:47:08 PST 
Use existing code for redirects when using NETWORK_SESSION
Comment 1 Alex Christensen 2015-12-11 18:47:23 PST 
Created attachment 267213 [details]
Patch
Comment 2 Alex Christensen 2015-12-12 17:10:32 PST 
Comment on attachment 267213 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=267213&action=review

> Source/WebKit2/NetworkProcess/NetworkLoad.cpp:169
>      sharedWillSendRedirectedRequest(request, response);
> -    completionHandler(request);
> +    ASSERT(!m_redirectCompletionHandler);
> +    m_redirectCompletionHandler = completionHandler;

I need to set m_redirectCompletionHandler before calling sharedWillSendRedirectedRequest
Comment 3 Alex Christensen 2015-12-12 17:14:24 PST 
This fixes http/tests/cookies/set-cookie-on-redirect.html
rdar://problem/23860624
Comment 4 Alex Christensen 2015-12-12 17:17:04 PST 
Created attachment 267248 [details]
Patch
Comment 5 Darin Adler 2015-12-13 13:44:21 PST 
Comment on attachment 267248 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=267248&action=review

> Source/WebKit2/NetworkProcess/NetworkLoad.cpp:107
> +        m_task->cancel();

Incorrect indentation?

> Source/WebKit2/NetworkProcess/NetworkLoad.h:125
> +    RedirectCompletionHandler m_redirectCompletionHandler { nullptr };

std::function doesn't need nullptr initialization to be null
Comment 6 Alex Christensen 2015-12-14 13:54:10 PST 
https://trac.webkit.org/changeset/194043