Bug 152202 - Reconsider B3's constant motion policy
Summary: Reconsider B3's constant motion policy
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: JavaScriptCore (show other bugs)
Version: WebKit Nightly Build
Hardware: All All
: P2 Normal
Assignee: Filip Pizlo
URL:
Keywords:
: 152107 (view as bug list)
Depends on:
Blocks: 150279
  Show dependency tree / graph
 
Reported: 2015-12-11 16:19 PST by Filip Pizlo
Modified: 2016-01-19 12:55 PST (History)
11 users (show)

See Also:

Attachments
the patch (23.35 KB, patch)
2016-01-19 12:40 PST, Filip Pizlo 		no flags Details | Formatted Diff | Diff
the patch (22.78 KB, patch)
2016-01-19 12:44 PST, Filip Pizlo 		ggaren: review+
Details | Formatted Diff | Diff
Show Obsolete (1) View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Filip Pizlo 2015-12-11 16:19:27 PST 
It appears that on asm.js code, our constant motion is wrong:

- It pins tags to registers even though the tags are not used frequently enough to warrant it.
- It doesn't pin the heap base to a register even though it is used frequently enough to warrant it.
Comment 1 Filip Pizlo 2015-12-11 16:20:41 PST 
*** Bug 152107 has been marked as a duplicate of this bug. ***
Comment 2 Filip Pizlo 2016-01-19 12:40:58 PST 
Created attachment 269282 [details]
the patch
Comment 3 Filip Pizlo 2016-01-19 12:44:35 PST 
Created attachment 269283 [details]
the patch
Comment 4 Geoffrey Garen 2016-01-19 12:54:19 PST 
Comment on attachment 269283 [details]
the patch

r=me
Comment 5 Filip Pizlo 2016-01-19 12:55:58 PST 
Landed in http://trac.webkit.org/changeset/195307