Bug 152196 - Perf dashboard's buildbot sync config JSON duplicates too much information
Summary: Perf dashboard's buildbot sync config JSON duplicates too much information
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: Perf Dashboard (show other bugs)
Version: WebKit Nightly Build
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Ryosuke Niwa
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2015-12-11 15:52 PST by Ryosuke Niwa
Modified: 2016-02-16 13:53 PST (History)
6 users (show)

See Also:


Attachments
Added shared configurations (2.10 KB, patch)
2015-12-11 15:56 PST, Ryosuke Niwa
slewis: review+
Details | Formatted Diff | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Ryosuke Niwa 2015-12-11 15:52:58 PST
Consolidate the duplicated entries.
Comment 1 Ryosuke Niwa 2015-12-11 15:56:31 PST
Created attachment 267196 [details]
Added shared configurations
Comment 2 dewei_zhu 2015-12-11 15:59:46 PST
Comment on attachment 267196 [details]
Added shared configurations

This will definitely simplify  the process of enabling a new test. Is the data format documented anywhere?
Comment 3 Stephanie Lewis 2015-12-11 16:07:40 PST
Comment on attachment 267196 [details]
Added shared configurations

View in context: https://bugs.webkit.org/attachment.cgi?id=267196&action=review

> Websites/perf.webkit.org/tools/sync-with-buildbot.py:78
> +                config[key].update(value)

Would we ever have a list?
Comment 4 Ryosuke Niwa 2015-12-11 16:11:54 PST
Comment on attachment 267196 [details]
Added shared configurations

View in context: https://bugs.webkit.org/attachment.cgi?id=267196&action=review

>> Websites/perf.webkit.org/tools/sync-with-buildbot.py:78
>> +                config[key].update(value)
> 
> Would we ever have a list?

If we did have a list, then overriding the old list with the new one (not merging is the right approach
so the code below (config[key] = value) will suffice.
Comment 5 Ryosuke Niwa 2015-12-11 16:12:00 PST
Committed r193992: <http://trac.webkit.org/changeset/193992>