Bug 152185 - Refactoring to reduce potential cut-paste errors with the FTL ICs.
Summary: Refactoring to reduce potential cut-paste errors with the FTL ICs.
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: JavaScriptCore (show other bugs)
Version: WebKit Local Build
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Mark Lam
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2015-12-11 13:32 PST by Mark Lam
Modified: 2015-12-11 15:03 PST (History)
4 users (show)

See Also:

Attachments
proposed patch. (40.82 KB, patch)
2015-12-11 13:49 PST, Mark Lam 		no flags Details | Formatted Diff | Diff
patch 2: revert unneeded part where I pushed m_name down to InlineCacheDescriptor. (38.67 KB, patch)
2015-12-11 14:40 PST, Mark Lam 		saam: review+
Details | Formatted Diff | Diff
Show Obsolete (1) View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Mark Lam 2015-12-11 13:32:01 PST 
Patch coming.
Comment 1 Mark Lam 2015-12-11 13:49:29 PST 
Created attachment 267185 [details]
proposed patch.
Comment 2 WebKit Commit Bot 2015-12-11 13:51:00 PST 
Attachment 267185 [details] did not pass style-queue:


ERROR: Source/JavaScriptCore/ftl/FTLInlineCacheDescriptor.h:92:  Wrong number of spaces before statement. (expected: 12)  [whitespace/indent] [4]
ERROR: Source/JavaScriptCore/ftl/FTLInlineCacheDescriptor.h:150:  Wrong number of spaces before statement. (expected: 12)  [whitespace/indent] [4]
ERROR: Source/JavaScriptCore/ftl/FTLInlineCacheDescriptor.h:243:  Wrong number of spaces before statement. (expected: 12)  [whitespace/indent] [4]
Total errors found: 3 in 6 files


If any of these errors are false positives, please file a bug against check-webkit-style.
Comment 3 Mark Lam 2015-12-11 14:40:33 PST 
Created attachment 267190 [details]
patch 2: revert unneeded part where I pushed m_name down to InlineCacheDescriptor.
Comment 4 Saam Barati 2015-12-11 14:59:43 PST 
Comment on attachment 267190 [details]
patch 2: revert unneeded part where I pushed m_name down to InlineCacheDescriptor.

r=me
Comment 5 Mark Lam 2015-12-11 15:03:12 PST 
Thanks for the review.  Landed in r193985: <http://trac.webkit.org/r193985>.