Bug 152173 – REGRESSION (r191613): Web Inspector: Can't type spaces when editing DOM nodes

• Status: VERIFIED
• Resolution: FIXED
• Component: Web Inspector

[Michael Bailey]

At some point recently, I stopped being able to type spaces when editing DOM nodes in the Web Inspector's "Elements" tab. Typing any other character works, and I can work around the issue by copying and pasting spaces.

STR:
1. Open the Web Inspector to the "Elements" tab.
2. Double click any element or text node to edit its contents.
3. Press the space bar.

Expected:
Spaces should be typed into the selected field.

Actual:
Nothing happens.

This works as expected in Safari 9.0.2 (11601.3.9), but is broken in WebKit r193949. I think it broke within the last couple weeks.

[Radar WebKit Bug Importer]

<rdar://problem/23857868>

[Nikita Vasilyev]

Bisecting tells me that the regression was introduced by:
http://trac.webkit.org/changeset/191613

[Joseph Pecoraro]

(In reply to comment #2)
> Bisecting tells me that the regression was introduced by:
> http://trac.webkit.org/changeset/191613

Really? Hah. I wonder if the keyboard shortcuts should start out disabled, since they are only meant to be enabled / disabled when the TabContentView is shown, but they don't look disabled when created.

[Joseph Pecoraro]

Created attachment 267228 [details]
[PATCH] Proposed Fix

[WebKit Commit Bot]

Comment on attachment 267228 [details]
[PATCH] Proposed Fix

Clearing flags on attachment: 267228

Committed r194009: <http://trac.webkit.org/changeset/194009>

[WebKit Commit Bot]

All reviewed patches have been landed.  Closing bug.

[Michael Bailey]

Looks good in the r194012 nightly. Thanks!