RESOLVED FIXED Bug 152164
B3 should reduce Shl(<S|Z>Shr(@x, @const), @const) to BitAnd(@x, -(1<<@const)) 
https://bugs.webkit.org/show_bug.cgi?id=152164
Summary B3 should reduce Shl(<S|Z>Shr(@x, @const), @const) to BitAnd(@x, -(1<<@const))
Filip Pizlo
Reported 2015-12-10 18:59:05 PST
Things.
Attachments
Patch (6.57 KB, patch)
2019-02-11 16:57 PST, Robin Morisset 		no flags
DetailsFormatted DiffDiff
Patch (6.40 KB, patch)
2019-02-11 16:58 PST, Robin Morisset 		ews-watchlist: commit-queue-
DetailsFormatted DiffDiff
Archive of layout-test-results from ews124 for ios-simulator-wk2 (18.31 MB, application/zip)
2019-02-11 19:08 PST, EWS Watchlist 		no flags
Details
Archive of layout-test-results from ews112 for mac-highsierra (2.20 MB, application/zip)
2019-02-11 19:18 PST, EWS Watchlist 		no flags
Details
Patch (6.40 KB, patch)
2019-02-12 13:50 PST, Robin Morisset 		ews-watchlist: commit-queue-
DetailsFormatted DiffDiff
Archive of layout-test-results from ews113 for mac-highsierra (2.50 MB, application/zip)
2019-02-12 15:25 PST, EWS Watchlist 		no flags
Details
Patch (6.55 KB, patch)
2019-03-17 17:38 PDT, Robin Morisset 		ews-watchlist: commit-queue-
DetailsFormatted DiffDiff
Archive of layout-test-results from ews117 for mac-highsierra (2.40 MB, application/zip)
2019-03-17 20:22 PDT, EWS Watchlist 		no flags
Details
Patch (6.61 KB, patch)
2019-03-17 23:44 PDT, Robin Morisset 		no flags
DetailsFormatted DiffDiff
Show Obsolete (8) View All Add attachment proposed patch, testcase, etc.
Robin Morisset
Comment 1 2019-02-11 16:57:24 PST
Created attachment 361732 [details] Patch
Robin Morisset
Comment 2 2019-02-11 16:58:31 PST
Created attachment 361733 [details] Patch This time without useless include.
EWS Watchlist
Comment 3 2019-02-11 19:08:01 PST
Comment on attachment 361733 [details] Patch Attachment 361733 [details] did not pass ios-sim-ews (ios-simulator-wk2): Output: https://webkit-queues.webkit.org/results/11116089 New failing tests: fast/viewport/ios/device-width-viewport-after-changing-view-scale.html
EWS Watchlist
Comment 4 2019-02-11 19:08:04 PST
Created attachment 361754 [details] Archive of layout-test-results from ews124 for ios-simulator-wk2 The attached test failures were seen while running run-webkit-tests on the ios-sim-ews. Bot: ews124 Port: ios-simulator-wk2 Platform: Mac OS X 10.13.6
EWS Watchlist
Comment 5 2019-02-11 19:18:37 PST
Comment on attachment 361733 [details] Patch Attachment 361733 [details] did not pass mac-debug-ews (mac): Output: https://webkit-queues.webkit.org/results/11116342 New failing tests: workers/wasm-hashset.html
EWS Watchlist
Comment 6 2019-02-11 19:18:39 PST
Created attachment 361755 [details] Archive of layout-test-results from ews112 for mac-highsierra The attached test failures were seen while running run-webkit-tests on the mac-debug-ews. Bot: ews112 Port: mac-highsierra Platform: Mac OS X 10.13.6
Robin Morisset
Comment 7 2019-02-12 13:50:44 PST
Created attachment 361833 [details] Patch Same patch as before, to see if the tests were just being flaky (I don't see how a patch to B3 can cause failure of a layout test).
EWS Watchlist
Comment 8 2019-02-12 15:25:46 PST
Comment on attachment 361833 [details] Patch Attachment 361833 [details] did not pass mac-debug-ews (mac): Output: https://webkit-queues.webkit.org/results/11126320 New failing tests: http/tests/inspector/network/resource-initiatorNode.html
EWS Watchlist
Comment 9 2019-02-12 15:25:49 PST
Created attachment 361852 [details] Archive of layout-test-results from ews113 for mac-highsierra The attached test failures were seen while running run-webkit-tests on the mac-debug-ews. Bot: ews113 Port: mac-highsierra Platform: Mac OS X 10.13.6
Robin Morisset
Comment 10 2019-03-17 17:38:21 PDT
Created attachment 364988 [details] Patch I've tried and failed to repro the test failures seen by EWS, so let's send it back to the bots and hope it was just some flakiness.
EWS Watchlist
Comment 11 2019-03-17 20:22:15 PDT
Comment on attachment 364988 [details] Patch Attachment 364988 [details] did not pass mac-debug-ews (mac): Output: https://webkit-queues.webkit.org/results/11545722 New failing tests: workers/wasm-hashset.html
EWS Watchlist
Comment 12 2019-03-17 20:22:17 PDT
Created attachment 364997 [details] Archive of layout-test-results from ews117 for mac-highsierra The attached test failures were seen while running run-webkit-tests on the mac-debug-ews. Bot: ews117 Port: mac-highsierra Platform: Mac OS X 10.13.6
Robin Morisset
Comment 13 2019-03-17 21:09:39 PDT
Ok, so this is really not flakiness. I will have to understand why it did not reproduce locally.
Robin Morisset
Comment 14 2019-03-17 23:44:42 PDT
Created attachment 365002 [details] Patch Found the problem: I had just forgotten to add the constant to the basic block.
WebKit Commit Bot
Comment 15 2019-03-18 08:29:15 PDT
Comment on attachment 365002 [details] Patch Clearing flags on attachment: 365002 Committed r243065: <https://trac.webkit.org/changeset/243065>
WebKit Commit Bot
Comment 16 2019-03-18 08:29:17 PDT
All reviewed patches have been landed. Closing bug.
Radar WebKit Bug Importer
Comment 17 2019-03-18 08:30:54 PDT
<rdar://problem/48979516>
Note You need to log in before you can comment on or make changes to this bug.