B3 should reduce Shl(<S|Z>Shr(@x, @const), @const) to BitAnd(@x, -(1<<@const))

[Filip Pizlo]

Things.

[Robin Morisset]

Created attachment 361732 [details]
Patch

[Robin Morisset]

Created attachment 361733 [details]
Patch

This time without useless include.

[EWS Watchlist]

Comment on attachment 361733 [details]
Patch

Attachment 361733 [details] did not pass ios-sim-ews (ios-simulator-wk2):
Output: https://webkit-queues.webkit.org/results/11116089

New failing tests:
fast/viewport/ios/device-width-viewport-after-changing-view-scale.html

[EWS Watchlist]

Created attachment 361754 [details]
Archive of layout-test-results from ews124 for ios-simulator-wk2

The attached test failures were seen while running run-webkit-tests on the ios-sim-ews.
Bot: ews124  Port: ios-simulator-wk2  Platform: Mac OS X 10.13.6

[EWS Watchlist]

Comment on attachment 361733 [details]
Patch

Attachment 361733 [details] did not pass mac-debug-ews (mac):
Output: https://webkit-queues.webkit.org/results/11116342

New failing tests:
workers/wasm-hashset.html

[EWS Watchlist]

Created attachment 361755 [details]
Archive of layout-test-results from ews112 for mac-highsierra

The attached test failures were seen while running run-webkit-tests on the mac-debug-ews.
Bot: ews112  Port: mac-highsierra  Platform: Mac OS X 10.13.6

[Robin Morisset]

Created attachment 361833 [details]
Patch

Same patch as before, to see if the tests were just being flaky (I don't see how a patch to B3 can cause failure of a layout test).

[EWS Watchlist]

Comment on attachment 361833 [details]
Patch

Attachment 361833 [details] did not pass mac-debug-ews (mac):
Output: https://webkit-queues.webkit.org/results/11126320

New failing tests:
http/tests/inspector/network/resource-initiatorNode.html

[EWS Watchlist]

Created attachment 361852 [details]
Archive of layout-test-results from ews113 for mac-highsierra

The attached test failures were seen while running run-webkit-tests on the mac-debug-ews.
Bot: ews113  Port: mac-highsierra  Platform: Mac OS X 10.13.6

[Robin Morisset]

Created attachment 364988 [details]
Patch

I've tried and failed to repro the test failures seen by EWS, so let's send it back to the bots and hope it was just some flakiness.

[EWS Watchlist]

Comment on attachment 364988 [details]
Patch

Attachment 364988 [details] did not pass mac-debug-ews (mac):
Output: https://webkit-queues.webkit.org/results/11545722

New failing tests:
workers/wasm-hashset.html

[EWS Watchlist]

Created attachment 364997 [details]
Archive of layout-test-results from ews117 for mac-highsierra

The attached test failures were seen while running run-webkit-tests on the mac-debug-ews.
Bot: ews117  Port: mac-highsierra  Platform: Mac OS X 10.13.6

[Robin Morisset]

Ok, so this is really not flakiness. I will have to understand why it did not reproduce locally.

[Robin Morisset]

Created attachment 365002 [details]
Patch

Found the problem: I had just forgotten to add the constant to the basic block.

[WebKit Commit Bot]

Comment on attachment 365002 [details]
Patch

Clearing flags on attachment: 365002

Committed r243065: <https://trac.webkit.org/changeset/243065>

[WebKit Commit Bot]

All reviewed patches have been landed.  Closing bug.

[Radar WebKit Bug Importer]

<rdar://problem/48979516>