* SUMMARY check-for-inappropriate-objc-class-names should check all class names, not just externally visible ones. The script currently uses `nm -Ugjp` where `-g` filters the list of symbols down to "only global (external) symbols". Our frameworks should be clean and identify all ObjC classes with appropriately prefixed names, not just external symbols. This also helps with code readability.
Created attachment 267143 [details] [PATCH] Proposed Fix
Comment on attachment 267143 [details] [PATCH] Proposed Fix Before you commit this, please verify that it doesn’t break Apple-internal projects that use this script.
I did check other projects, however I clearly missed iOS builds! I will fix iOS.
Created attachment 267150 [details] [PATCH] Proposed Fix Cover a few iOS cases I missed.
Attachment 267150 [details] did not pass style-queue: ERROR: Source/WebKit2/UIProcess/mac/RemoteLayerTreeDrawingAreaProxy.h:35: _WKOneShotDisplayLinkHandler is incorrectly named. Don't use underscores in your identifier names. [readability/naming/underscores] [4] Total errors found: 1 in 12 files If any of these errors are false positives, please file a bug against check-webkit-style.
Created attachment 267152 [details] [PATCH] Proposed Fix
Attachment 267152 [details] did not pass style-queue: ERROR: Source/WebKit2/UIProcess/mac/RemoteLayerTreeDrawingAreaProxy.h:35: _WKOneShotDisplayLinkHandler is incorrectly named. Don't use underscores in your identifier names. [readability/naming/underscores] [4] Total errors found: 1 in 12 files If any of these errors are false positives, please file a bug against check-webkit-style.
No need for the underscore prefix on internal classes. Only some private identifiers need to be underscore-prefixed.
Created attachment 267154 [details] [PATCH] Proposed Fix
Comment on attachment 267154 [details] [PATCH] Proposed Fix Clearing flags on attachment: 267154 Committed r193972: <http://trac.webkit.org/changeset/193972>
All reviewed patches have been landed. Closing bug.