Bug 152147 - Change skin tone support for two emoji
Summary: Change skin tone support for two emoji
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: Layout and Rendering (show other bugs)
Version: WebKit Nightly Build
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Enrica Casucci
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2015-12-10 12:09 PST by Enrica Casucci
Modified: 2015-12-14 11:23 PST (History)
2 users (show)

See Also:

Attachments
Patch (12.24 KB, patch)
2015-12-10 12:17 PST, Enrica Casucci 		darin: review+
Details | Formatted Diff | Diff
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Enrica Casucci 2015-12-10 12:09:28 PST 
Horse race emoji (1F3C7) should no longer have skin tone variation.
Sleuth/Spy emoji (!F575) should instead have skin tone variation.

rdar://problem/23716993
rdar://problem/23716344
Comment 1 Enrica Casucci 2015-12-10 12:17:43 PST 
Created attachment 267119 [details]
Patch
Comment 2 Enrica Casucci 2015-12-10 12:22:52 PST 
Committed revision 193922.
Comment 3 Ryan Haddad 2015-12-10 13:44:53 PST 
The test modified with this change is failing on Yosemite

<https://build.webkit.org/builders/Apple%20Yosemite%20Release%20WK2%20%28Tests%29/builds/10485>

--- /Volumes/Data/slave/yosemite-release-tests-wk2/build/layout-test-results/fast/text/emoji-expected.txt
+++ /Volumes/Data/slave/yosemite-release-tests-wk2/build/layout-test-results/fast/text/emoji-actual.txt
@@ -11,9 +11,9 @@
         RenderText {#text} at (0,0) size 21x21
           text run at (0,0) width 21: "\x{D83D}\x{DE01}"
       RenderBlock {DIV} at (0,57) size 784x420
-        RenderText {#text} at (0,6) size 512x74
-          text run at (0,6) width 512: "\x{D83D}\x{DC66}\x{D83C}\x{DFFB}\x{D83D}\x{DC69}\x{D83C}\x{DFFC}\x{D83D}\x{DC66}\x{D83C}\x{DFFE}\x{2764}\x{FE0F}\x{D83D}\x{DC8B}\x{D83D}\x{DD75}\x{D83C}\x{DFFB}\x{D83C}\x{DFC7}\x{D83C}\x{DFFB}"
-        RenderBR {BR} at (512,64) size 0x0
+        RenderText {#text} at (0,6) size 477x74
+          text run at (0,6) width 477: "\x{D83D}\x{DC66}\x{D83C}\x{DFFB}\x{D83D}\x{DC69}\x{D83C}\x{DFFC}\x{D83D}\x{DC66}\x{D83C}\x{DFFE}\x{2764}\x{FE0F}\x{D83D}\x{DC8B}\x{D83D}\x{DD75}\x{D83C}\x{DFFB}\x{D83C}\x{DFC7}\x{D83C}\x{DFFB}"
+        RenderBR {BR} at (476,64) size 1x0
         RenderText {#text} at (0,90) size 432x74
           text run at (0,90) width 432: "\x{D83D}\x{DC68}\x{200D}\x{D83D}\x{DC69}\x{200D}\x{D83D}\x{DC66} \x{D83D}\x{DC68}\x{200D}\x{D83D}\x{DC69}\x{200D}\x{D83D}\x{DC67} \x{D83D}\x{DC6A} \x{D83D}\x{DC66}\x{D83C}\x{DFFB}\x{D83D}\x{DC69}\x{D83C}\x{DFFC}\x{D83D}\x{DC66}\x{D83C}\x{DFFE}"
         RenderBR {BR} at (432,148) size 0x0
Comment 4 Ryan Haddad 2015-12-10 15:55:35 PST 
After speaking with Enrica, we are just going to rebaseline this test for Yosemite.
Comment 5 Ryan Haddad 2015-12-10 16:00:31 PST 
Rebaselined in r193931. Closing as resolved.