Bug 152146 - Remove additional simulator checks before running layout-tests
Summary: Remove additional simulator checks before running layout-tests
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: Tools / Tests (show other bugs)
Version: WebKit Nightly Build
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Aakash Jain
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2015-12-10 11:50 PST by Aakash Jain
Modified: 2017-03-15 17:17 PDT (History)
6 users (show)

See Also:


Attachments
Proposed patch (3.38 KB, patch)
2015-12-10 11:59 PST, Aakash Jain
no flags Details | Formatted Diff | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Aakash Jain 2015-12-10 11:50:47 PST
Some of the checks like booting up and shutting down the simulator device are no longer required. Now we are creating a new simulator device and new copy of Simulator app in each run, as opposed to earlier setup in which we were reusing the old Simulator. These additional checks takes a lot of time (especially in multi-simulator environment) and doesn't add much values. We should remove these checks.
Comment 1 Aakash Jain 2015-12-10 11:59:01 PST
Created attachment 267117 [details]
Proposed patch
Comment 2 WebKit Commit Bot 2015-12-10 12:45:17 PST
Comment on attachment 267117 [details]
Proposed patch

Clearing flags on attachment: 267117

Committed r193923: <http://trac.webkit.org/changeset/193923>
Comment 3 WebKit Commit Bot 2015-12-10 12:45:21 PST
All reviewed patches have been landed.  Closing bug.