Bug 152135 - [iOS Simulator] fast/viewport/ios/width-is-device-width-overflowing* tests failing
Summary: [iOS Simulator] fast/viewport/ios/width-is-device-width-overflowing* tests fa...
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: New Bugs (show other bugs)
Version: WebKit Nightly Build
Hardware: iPhone / iPad iOS 9.0
: P2 Normal
Assignee: Ryan Haddad
URL:
Keywords:
Depends on:
Blocks: 152130
  Show dependency treegraph
 
Reported: 2015-12-10 09:10 PST by Ryan Haddad
Modified: 2015-12-15 19:10 PST (History)
5 users (show)

See Also:


Attachments
Patch (6.86 KB, patch)
2015-12-15 16:56 PST, Ryan Haddad
no flags Details | Formatted Diff | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Ryan Haddad 2015-12-10 09:10:28 PST
[iOS Simulator] fast/viewport/ios/width-is-device-width-overflowing* tests failing

fast/viewport/ios/width-is-device-width-overflowing-body-overflow-hidden-tall.html
fast/viewport/ios/width-is-device-width-overflowing-body-overflow-hidden.html
fast/viewport/ios/width-is-device-width-overflowing-no-shrink-to-fit.html
fast/viewport/ios/width-is-device-width-overflowing.html

<https://build.webkit.org/results/Apple%20iOS%209%20Simulator%20Release%20WK2%20(Tests)/r193902%20(1662)/results.html>
Comment 1 Ryan Haddad 2015-12-14 13:04:37 PST
Marked as failing on iOS simulator in <http://trac.webkit.org/changeset/194053>
Comment 2 Ryan Haddad 2015-12-14 14:13:02 PST
Missed the ios-simulator-wk2 [ Pass ] expectation. Removed with r194058.
Comment 3 Alexey Proskuryakov 2015-12-14 20:23:22 PST
Could you please post the failure into the bug?

There is one more test in this directory, width-is-device-width.html. Looks like it was passing, but as a result of these changes, it got skipped.
Comment 4 Ryan Haddad 2015-12-14 20:36:15 PST
Of course. Sorry about the collateral damage there.

Diffs below:
--- /Volumes/Data/slave/ios-simulator-9-release-tests-wk2/build/layout-test-results/fast/viewport/ios/width-is-device-width-overflowing-body-overflow-hidden-tall-expected.txt
+++ /Volumes/Data/slave/ios-simulator-9-release-tests-wk2/build/layout-test-results/fast/viewport/ios/width-is-device-width-overflowing-body-overflow-hidden-tall-actual.txt
@@ -1,7 +1,7 @@
 Viewport: width=device-width
 
-scale	1.00000
+scale	1.05263
 maxScale	5.00000
-minScale	1.00000
-visibleRect	{"left":"0.00000","top":"0.00000","width":"320.00000","height":"480.00000"}
+minScale	1.05263
+visibleRect	{"left":"0.00000","top":"0.00000","width":"303.99999","height":"455.99998"}
 
--- /Volumes/Data/slave/ios-simulator-9-release-tests-wk2/build/layout-test-results/fast/viewport/ios/width-is-device-width-overflowing-body-overflow-hidden-expected.txt
+++ /Volumes/Data/slave/ios-simulator-9-release-tests-wk2/build/layout-test-results/fast/viewport/ios/width-is-device-width-overflowing-body-overflow-hidden-actual.txt
@@ -1,7 +1,7 @@
 Viewport: width=device-width
 
-scale	1.00000
+scale	5.00000
 maxScale	5.00000
-minScale	0.32653
-visibleRect	{"left":"0.00000","top":"0.00000","width":"320.00000","height":"480.00000"}
+minScale	5.00000
+visibleRect	{"left":"0.00000","top":"0.00000","width":"64.00000","height":"96.00000"}
 

--- /Volumes/Data/slave/ios-simulator-9-release-tests-wk2/build/layout-test-results/fast/viewport/ios/width-is-device-width-overflowing-no-shrink-to-fit-expected.txt
+++ /Volumes/Data/slave/ios-simulator-9-release-tests-wk2/build/layout-test-results/fast/viewport/ios/width-is-device-width-overflowing-no-shrink-to-fit-actual.txt
@@ -1,7 +1,7 @@
 Viewport: width=device-width, shrink-to-fit=no
 
-scale	0.32653
+scale	1.00000
 maxScale	5.00000
-minScale	0.32653
-visibleRect	{"left":"0.00000","top":"0.00000","width":"980.00000","height":"1470.00000"}
+minScale	1.00000
+visibleRect	{"left":"0.00000","top":"0.00000","width":"320.00000","height":"480.00000"}
 
--- /Volumes/Data/slave/ios-simulator-9-release-tests-wk2/build/layout-test-results/fast/viewport/ios/width-is-device-width-overflowing-expected.txt
+++ /Volumes/Data/slave/ios-simulator-9-release-tests-wk2/build/layout-test-results/fast/viewport/ios/width-is-device-width-overflowing-actual.txt
@@ -1,7 +1,7 @@
 Viewport: width=device-width
 
-scale	1.00000
+scale	0.31746
 maxScale	5.00000
-minScale	1.00000
-visibleRect	{"left":"0.00000","top":"0.00000","width":"320.00000","height":"480.00000"}
+minScale	0.31746
+visibleRect	{"left":"0.00000","top":"0.00000","width":"1007.99997","height":"1511.99995"}
Comment 5 Tim Horton 2015-12-15 09:53:52 PST
I think this was "intentional", but you should talk to Simon.
Comment 6 Simon Fraser (smfr) 2015-12-15 15:56:36 PST
I didn't change anything here since those tests landed. Would be good to have a regression point.
Comment 7 Simon Fraser (smfr) 2015-12-15 16:52:58 PST
I think the new results are actually correct. I will confirm and rebaseline.
Comment 8 Ryan Haddad 2015-12-15 16:53:56 PST
I have a local change to rebaseline with the current results and update the TestExpectations files. Give me a few minutes and I'll upload it.
Comment 9 Ryan Haddad 2015-12-15 16:56:42 PST
Created attachment 267413 [details]
Patch
Comment 10 WebKit Commit Bot 2015-12-15 19:10:17 PST
Comment on attachment 267413 [details]
Patch

Clearing flags on attachment: 267413

Committed r194129: <http://trac.webkit.org/changeset/194129>
Comment 11 WebKit Commit Bot 2015-12-15 19:10:21 PST
All reviewed patches have been landed.  Closing bug.