Bug 152108 – ES6 Class syntax. Invoking method of parent class in constructor before super() lead to crash

• Status: RESOLVED
• Resolution: FIXED
• Component: JavaScriptCore

[GSkachkov]

Invoking method of parent class in constructor before super() lead to crash. See example:
<script>
   class A {
      getValue() {
         return 'test-value';
      }
   }

  class B extends A {
     constructor () {
        let _value  = super.getValue();
        super();
        this.value = _value;
     }
  }

  let b = new B();
  console.log(b.value);
</script>

[GSkachkov]

Created attachment 267075 [details]
dump_error

Error dump, that I received on r193804

[Joseph Pecoraro]

(In reply to comment #0)
> Invoking method of parent class in constructor before super() lead to crash.
>
>   class B extends A {
>      constructor () {
>         let _value  = super.getValue();
>         super();
>         this.value = _value;
>      }
>   }

I think this was supposed to be an arrow function:

    let _value = () => { super.getValue() };
    _value();
    super();

At least Based on the FIXME in the LayoutTests/js test.

However, it looks like this has been fixed! Lets enable the test to ensure we get a bit extra coverage and remove the FIXMEs in LayoutTests.

[Joseph Pecoraro]

Created attachment 274980 [details]
[PATCH] Proposed Fix

[WebKit Commit Bot]

Comment on attachment 274980 [details]
[PATCH] Proposed Fix

Clearing flags on attachment: 274980

Committed r198714: <http://trac.webkit.org/changeset/198714>

[WebKit Commit Bot]

All reviewed patches have been landed.  Closing bug.