Bug 152103 - REGRESSION: code-review-tests.html fails with error "Received an error at line 214"
Summary: REGRESSION: code-review-tests.html fails with error "Received an error at lin...
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: Tools / Tests (show other bugs)
Version: WebKit Local Build
Hardware: All All
: P2 Normal
Assignee: Daniel Bates
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2015-12-09 19:32 PST by Daniel Bates
Modified: 2015-12-09 19:43 PST (History)
4 users (show)

See Also:


Attachments
Patch (3.78 KB, patch)
2015-12-09 19:36 PST, Daniel Bates
darin: review+
Details | Formatted Diff | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Daniel Bates 2015-12-09 19:32:50 PST
The unit tests in the file code-review-tests.html fail due to a JavaScript TypeError.

Steps to reproduce:

1. Open the page Websites/bugs.webkit.org/code-review-test.html, <http://trac.webkit.org/export/193888/trunk/Websites/bugs.webkit.org/code-review-test.html>.

Then the following text can be seen on the page:

"FAIL: Received an error at line 214"

And in the console we see the following error:

[Error] TypeError: undefined is not an object (evaluating '$('.overallComments textarea').val().trim')
    _json (code-review.js:213)
    save (code-review.js:253)
    saveDraftComments (code-review.js:333)
    acceptComment (code-review.js:1450)
    testSaveCommentsWithMissingLineIds (code-review-test.html:445)
    (anonymous function) (code-review-test.html:460)

I am using Safari Version 9.0.2 (11601.3.9) on OS X 10.11.2 (15C49).
Comment 1 Daniel Bates 2015-12-09 19:36:02 PST
Created attachment 267065 [details]
Patch
Comment 2 Daniel Bates 2015-12-09 19:43:09 PST
Committed r193889: <http://trac.webkit.org/changeset/193889>