Bug 152090 - <video>/<audio> should make use of the parsed media attribute on sources
Summary: <video>/<audio> should make use of the parsed media attribute on sources
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: Media (show other bugs)
Version: WebKit Nightly Build
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Dave Hyatt
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2015-12-09 12:43 PST by Dave Hyatt
Modified: 2016-01-05 00:53 PST (History)
5 users (show)

See Also:

Attachments
Patch (3.27 KB, patch)
2015-12-10 12:09 PST, Dave Hyatt 		darin: review+
Details | Formatted Diff | Diff
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Dave Hyatt 2015-12-09 12:43:10 PST 
<video>/<audio> should make use of the parsed media attribute on sources now that we have cached it in a parsed form for <picture> support.

See https://bugs.webkit.org/show_bug.cgi?id=152013
Comment 1 Dave Hyatt 2015-12-10 12:09:29 PST 
Created attachment 267118 [details]
Patch
Comment 2 Darin Adler 2015-12-10 12:13:02 PST 
Comment on attachment 267118 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=267118&action=review

> Source/WebCore/html/HTMLMediaElement.cpp:4150
> +            RefPtr<MediaQuerySet> media = source->mediaQuerySet();

Does this need to go into a local variable at all? Can’t we just use this below directly?

> Source/WebCore/html/HTMLSourceElement.cpp:34
> +#if ENABLE(VIDEO)
>  #include "HTMLMediaElement.h"
> +#endif

If we are making this conditional we should put it in a separate paragraph below.

Does the include itself need to be conditional?
Comment 3 Dave Hyatt 2016-01-04 13:18:58 PST 
Fix landed in r194549.
Comment 4 Csaba Osztrogonác 2016-01-05 00:53:18 PST 
(In reply to comment #3)
> Fix landed in r194549.

The commit log was repeated 47 times. :( Dave, could you check your script?