Bug 152090 – <video>/<audio> should make use of the parsed media attribute on sources

• Status: RESOLVED
• Resolution: FIXED
• Component: Media

[Dave Hyatt]

<video>/<audio> should make use of the parsed media attribute on sources now that we have cached it in a parsed form for <picture> support.

See https://bugs.webkit.org/show_bug.cgi?id=152013

[Dave Hyatt]

Created attachment 267118 [details]
Patch

[Darin Adler]

Comment on attachment 267118 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=267118&action=review

> Source/WebCore/html/HTMLMediaElement.cpp:4150
> +            RefPtr<MediaQuerySet> media = source->mediaQuerySet();

Does this need to go into a local variable at all? Can’t we just use this below directly?

> Source/WebCore/html/HTMLSourceElement.cpp:34
> +#if ENABLE(VIDEO)
>  #include "HTMLMediaElement.h"
> +#endif

If we are making this conditional we should put it in a separate paragraph below.

Does the include itself need to be conditional?

[Dave Hyatt]

Fix landed in r194549.

[Csaba Osztrogonác]

(In reply to comment #3)
> Fix landed in r194549.

The commit log was repeated 47 times. :( Dave, could you check your script?