Bug 152086 – Fix bad link on the Feature Status page

• Status: RESOLVED
• Resolution: FIXED
• Component: WebKit Website

[Jon Davis]

There is a link to an old page on the feature status page that is not redirecting properly because of the relative path used.

[Jon Davis]

Created attachment 267031 [details]
Patch

[Daniel Bates]

Comment on attachment 267031 [details]
Patch

For your consideration I suggest elaborating further on the hyperlink that is broken in your ChangeLog entry.

[WebKit Commit Bot]

Comment on attachment 267031 [details]
Patch

Rejecting attachment 267031 [details] from commit-queue.

Failed to run "['/Volumes/Data/EWS/WebKit/Tools/Scripts/webkit-patch', '--status-host=webkit-queues.webkit.org', '--bot-id=webkit-cq-03', 'validate-changelog', '--check-oops', '--non-interactive', 267031, '--port=mac']" exit_code: 1 cwd: /Volumes/Data/EWS/WebKit

Last 500 characters of output:
a/EWS/WebKit/Tools/Scripts/webkitpy/tool/commands/stepsequence.py", line 73, in run_and_handle_errors
    self._run(tool, options, state)
  File "/Volumes/Data/EWS/WebKit/Tools/Scripts/webkitpy/tool/commands/stepsequence.py", line 67, in _run
    step(tool, options).run(state)
  File "/Volumes/Data/EWS/WebKit/Tools/Scripts/webkitpy/tool/steps/validatereviewer.py", line 54, in run
    if changelog_entry.has_valid_reviewer():
AttributeError: 'NoneType' object has no attribute 'has_valid_reviewer'

Full output: http://webkit-queues.webkit.org/results/538264

[Jon Davis]

Comment on attachment 267031 [details]
Patch

>Index: Websites/webkit.org/ChangeLog
>===================================================================
>--- Websites/webkit.org/ChangeLog	(revision 193847)
>+++ Websites/webkit.org/ChangeLog	(working copy)
>@@ -1,3 +1,12 @@
>+ 2015-12-09  Jonathan Davis  <[e-mail]>
>+
>+        Fixed the "contribute to features" link at the bottom of the Feature Status page.
>+        https://bugs.webkit.org/show_bug.cgi?id=152086
>+
>+        Reviewed by NOBODY (OOPS!).
>+
>+        * wp-content/themes/webkit/status.php:
>+
> 2015-12-09  Jonathan Davis  <[e-mail]>
> 
>         Fixed broken link: https://webkit.org/old/security/security-group-members.html
>Index: Websites/webkit.org/wp-content/themes/webkit/status.php
>===================================================================
>--- Websites/webkit.org/wp-content/themes/webkit/status.php	(revision 193832)
>+++ Websites/webkit.org/wp-content/themes/webkit/status.php	(working copy)
>@@ -382,7 +382,7 @@ h3 a[name], .admin-bar h3 a[name] {
>             <template id="success-template">
>                 <ul class="features" id="features-container"></ul>
>                 <p>Cannot find something? You can contact <a href="https://twitter.com/webkit">@webkit</a> on Twitter or contact the <a href="https://lists.webkit.org/mailman/listinfo/webkit-help">webkit-help</a> mailing list for questions.</p>
>-                <p>You can also <a href="coding/contributing.html">contribute to features</a> directly, the entire project is Open Source. To report bugs on existing features or check existing bug reports, see <a href="https://bugs.webkit.org">https://bugs.webkit.org</a>.</p>
>+                <p>You can also <a href="/contributing-code/">contribute to features</a> directly, the entire project is Open Source. To report bugs on existing features or check existing bug reports, see <a href="https://bugs.webkit.org">https://bugs.webkit.org</a>.</p>
>             </template>
>             <template id="error-template">
>                 <p>Error: unable to load the features list (<span id="error-message"></span>).</p>

[WebKit Commit Bot]

Comment on attachment 267031 [details]
Patch

Rejecting attachment 267031 [details] from commit-queue.

Failed to run "['/Volumes/Data/EWS/WebKit/Tools/Scripts/webkit-patch', '--status-host=webkit-queues.webkit.org', '--bot-id=webkit-cq-03', 'validate-changelog', '--check-oops', '--non-interactive', 267031, '--port=mac']" exit_code: 1 cwd: /Volumes/Data/EWS/WebKit

Last 500 characters of output:
a/EWS/WebKit/Tools/Scripts/webkitpy/tool/commands/stepsequence.py", line 73, in run_and_handle_errors
    self._run(tool, options, state)
  File "/Volumes/Data/EWS/WebKit/Tools/Scripts/webkitpy/tool/commands/stepsequence.py", line 67, in _run
    step(tool, options).run(state)
  File "/Volumes/Data/EWS/WebKit/Tools/Scripts/webkitpy/tool/steps/validatereviewer.py", line 54, in run
    if changelog_entry.has_valid_reviewer():
AttributeError: 'NoneType' object has no attribute 'has_valid_reviewer'

Full output: http://webkit-queues.webkit.org/results/778282

[WebKit Commit Bot]

Comment on attachment 267031 [details]
Patch

Rejecting attachment 267031 [details] from commit-queue.

Failed to run "['/Volumes/Data/EWS/WebKit/Tools/Scripts/webkit-patch', '--status-host=webkit-queues.webkit.org', '--bot-id=webkit-cq-02', 'validate-changelog', '--check-oops', '--non-interactive', 267031, '--port=mac']" exit_code: 1 cwd: /Volumes/Data/EWS/WebKit

Last 500 characters of output:
a/EWS/WebKit/Tools/Scripts/webkitpy/tool/commands/stepsequence.py", line 73, in run_and_handle_errors
    self._run(tool, options, state)
  File "/Volumes/Data/EWS/WebKit/Tools/Scripts/webkitpy/tool/commands/stepsequence.py", line 67, in _run
    step(tool, options).run(state)
  File "/Volumes/Data/EWS/WebKit/Tools/Scripts/webkitpy/tool/steps/validatereviewer.py", line 54, in run
    if changelog_entry.has_valid_reviewer():
AttributeError: 'NoneType' object has no attribute 'has_valid_reviewer'

Full output: http://webkit-queues.webkit.org/results/778341

[Timothy Hatcher]

Created attachment 270681 [details]
Patch for landing

[WebKit Commit Bot]

Comment on attachment 270681 [details]
Patch for landing

Rejecting attachment 270681 [details] from commit-queue.

Failed to run "['/Volumes/Data/EWS/WebKit/Tools/Scripts/webkit-patch', '--status-host=webkit-queues.webkit.org', '--bot-id=webkit-cq-02', 'validate-changelog', '--check-oops', '--non-interactive', 270681, '--port=mac']" exit_code: 1 cwd: /Volumes/Data/EWS/WebKit

Last 500 characters of output:
a/EWS/WebKit/Tools/Scripts/webkitpy/tool/commands/stepsequence.py", line 73, in run_and_handle_errors
    self._run(tool, options, state)
  File "/Volumes/Data/EWS/WebKit/Tools/Scripts/webkitpy/tool/commands/stepsequence.py", line 67, in _run
    step(tool, options).run(state)
  File "/Volumes/Data/EWS/WebKit/Tools/Scripts/webkitpy/tool/steps/validatereviewer.py", line 54, in run
    if changelog_entry.has_valid_reviewer():
AttributeError: 'NoneType' object has no attribute 'has_valid_reviewer'

Full output: http://webkit-queues.webkit.org/results/782848

[Timothy Hatcher]

Created attachment 270682 [details]
Patch for landing take 2

[WebKit Commit Bot]

Comment on attachment 270682 [details]
Patch for landing take 2

Clearing flags on attachment: 270682

Committed r196139: <http://trac.webkit.org/changeset/196139>

[WebKit Commit Bot]

All reviewed patches have been landed.  Closing bug.