Bug 152073 – [TexMap] Clean up BitmapTexturePool

• Status: RESOLVED
• Resolution: FIXED
• Component: New Bugs

[Zan Dobersek]

[TexMap] Clean up BitmapTexturePool

[Zan Dobersek]

Created attachment 267019 [details]
Patch

[WebKit Commit Bot]

Attachment 267019 [details] did not pass style-queue:


ERROR: Source/WebCore/platform/graphics/texmap/BitmapTexturePool.cpp:50:  More than one command on the same line  [whitespace/newline] [4]
ERROR: Source/WebCore/platform/graphics/texmap/BitmapTexturePool.cpp:77:  More than one command on the same line  [whitespace/newline] [4]
Total errors found: 2 in 4 files


If any of these errors are false positives, please file a bug against check-webkit-style.

[Daniel Bates]

Comment on attachment 267019 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=267019&action=review

> Source/WebCore/platform/graphics/texmap/BitmapTexturePool.h:63
> +        void markUsed() { m_timeLastUsed = monotonicallyIncreasingTime(); }

This is OK as-is. Maybe using the present tense in naming this method would be better: markIsInUse()?

> Source/WebCore/platform/graphics/texmap/BitmapTexturePool.h:66
> +        double m_timeLastUsed;

This is minor. We tend to prefer names where the adjective/verb comes before the noun. Maybe a better name for this instance variable would be m_lastUsedTime?

[Zan Dobersek]

(In reply to comment #3)
> Comment on attachment 267019 [details]
> Patch
> 
> View in context:
> https://bugs.webkit.org/attachment.cgi?id=267019&action=review
> 
> > Source/WebCore/platform/graphics/texmap/BitmapTexturePool.h:63
> > +        void markUsed() { m_timeLastUsed = monotonicallyIncreasingTime(); }
> 
> This is OK as-is. Maybe using the present tense in naming this method would
> be better: markIsInUse()?
> 
> > Source/WebCore/platform/graphics/texmap/BitmapTexturePool.h:66
> > +        double m_timeLastUsed;
> 
> This is minor. We tend to prefer names where the adjective/verb comes before
> the noun. Maybe a better name for this instance variable would be
> m_lastUsedTime?

Thanks for the comment, adjusted the names so they make a tad more sense.

[Zan Dobersek]

Created attachment 267077 [details]
Patch for landing

Patch for landing, including an attempt to fix the Windows EWS bot.

[WebKit Commit Bot]

Attachment 267077 [details] did not pass style-queue:


ERROR: Source/WebCore/platform/graphics/texmap/BitmapTexturePool.cpp:50:  More than one command on the same line  [whitespace/newline] [4]
ERROR: Source/WebCore/platform/graphics/texmap/BitmapTexturePool.cpp:77:  More than one command on the same line  [whitespace/newline] [4]
Total errors found: 2 in 4 files


If any of these errors are false positives, please file a bug against check-webkit-style.

[Zan Dobersek]

Comment on attachment 267077 [details]
Patch for landing

Clearing flags on attachment: 267077

Committed r193897: <http://trac.webkit.org/changeset/193897>

[Zan Dobersek]

All reviewed patches have been landed.  Closing bug.