Bug 152068 - [CoordinatedGraphics] Remove unnecessary guards in CoordinatedDrawingArea
Summary: [CoordinatedGraphics] Remove unnecessary guards in CoordinatedDrawingArea
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: WebKit EFL (show other bugs)
Version: WebKit Nightly Build
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Ryuan Choi
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2015-12-09 08:06 PST by Ryuan Choi
Modified: 2015-12-09 10:32 PST (History)
2 users (show)

See Also:


Attachments
Patch (5.60 KB, patch)
2015-12-09 08:08 PST, Ryuan Choi
no flags Details | Formatted Diff | Diff
Patch (5.60 KB, patch)
2015-12-09 08:09 PST, Ryuan Choi
no flags Details | Formatted Diff | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Ryuan Choi 2015-12-09 08:06:05 PST
CoordinatedDrawingArea is only for UI side compositor of CoordinatedGraphics.
So, COORDINATED_GRAPHICS_MULTIPROCESS guards are not necessary.
Comment 1 Ryuan Choi 2015-12-09 08:08:23 PST
Created attachment 267007 [details]
Patch
Comment 2 Ryuan Choi 2015-12-09 08:09:40 PST
Created attachment 267008 [details]
Patch
Comment 3 Gyuyoung Kim 2015-12-09 08:56:49 PST
Comment on attachment 267008 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=267008&action=review

> Source/WebKit2/WebProcess/WebPage/CoordinatedGraphics/CoordinatedDrawingArea.h:-71
> -#if USE(TEXTURE_MAPPER_GL) && PLATFORM(GTK)

Should this interface be removed as well ?
Comment 4 Ryuan Choi 2015-12-09 09:01:29 PST
Comment on attachment 267008 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=267008&action=review

>> Source/WebKit2/WebProcess/WebPage/CoordinatedGraphics/CoordinatedDrawingArea.h:-71
>> -#if USE(TEXTURE_MAPPER_GL) && PLATFORM(GTK)
> 
> Should this interface be removed as well ?

DrawingAreaImpl still use it while CoordinatedDrawingArea does not use it now.

But, yoon should confirm this, IMO.
Comment 5 Gyuyoung Kim 2015-12-09 09:43:38 PST
Comment on attachment 267008 [details]
Patch

rs=me. yoon confirmed to remove *setNativeSurfaceHandleForComposting()*.
Comment 6 WebKit Commit Bot 2015-12-09 10:32:43 PST
Comment on attachment 267008 [details]
Patch

Clearing flags on attachment: 267008

Committed r193843: <http://trac.webkit.org/changeset/193843>
Comment 7 WebKit Commit Bot 2015-12-09 10:32:48 PST
All reviewed patches have been landed.  Closing bug.