Bug 152065 – [Streams API] imported/w3c/web-platform-tests/streams-api/readable-streams/cancel.html has a flaky test

• Status: RESOLVED
• Resolution: FIXED
• Component: New Bugs

[Xabier Rodríguez Calvar]

"ReadableStream cancellation: integration test on an infinite stream derived from a random push source" needs fixing.

[Xabier Rodríguez Calvar]

Checked with the spec and raised an issue in https://github.com/whatwg/streams/issues/413 as I think the error is timing error prone.

[Xabier Rodríguez Calvar]

Created attachment 267618 [details]
Patch

[youenn fablet]

Comment on attachment 267618 [details]
Patch

r=me

[WebKit Commit Bot]

Comment on attachment 267618 [details]
Patch

Clearing flags on attachment: 267618

Committed r194267: <http://trac.webkit.org/changeset/194267>

[WebKit Commit Bot]

All reviewed patches have been landed.  Closing bug.

[WebKit Commit Bot]

Re-opened since this is blocked by bug 152465

[youenn fablet]

Created attachment 267714 [details]
Patch

[youenn fablet]

(In reply to comment #7)
> Created attachment 267714 [details]
> Patch

Relanding after rebasing expected-text file according rollout of http://trac.webkit.org/changeset/194033

[WebKit Commit Bot]

Comment on attachment 267714 [details]
Patch

Rejecting attachment 267714 [details] from commit-queue.

New failing tests:
imported/w3c/web-platform-tests/streams-api/readable-streams/cancel.html
Full output: http://webkit-queues.webkit.org/results/584006

[WebKit Commit Bot]

Created attachment 267715 [details]
Archive of layout-test-results from webkit-cq-03 for mac-yosemite

The attached test failures were seen while running run-webkit-tests on the commit-queue.
Bot: webkit-cq-03  Port: mac-yosemite  Platform: Mac OS X 10.10.5

[Build Bot]

Comment on attachment 267714 [details]
Patch

Attachment 267714 [details] did not pass mac-ews (mac):
Output: http://webkit-queues.webkit.org/results/584222

New failing tests:
imported/w3c/web-platform-tests/streams-api/readable-streams/cancel.html

[Build Bot]

Created attachment 267716 [details]
Archive of layout-test-results from ews100 for mac-yosemite

The attached test failures were seen while running run-webkit-tests on the mac-ews.
Bot: ews100  Port: mac-yosemite  Platform: Mac OS X 10.10.5

[Build Bot]

Comment on attachment 267714 [details]
Patch

Attachment 267714 [details] did not pass mac-wk2-ews (mac-wk2):
Output: http://webkit-queues.webkit.org/results/584227

New failing tests:
imported/w3c/web-platform-tests/streams-api/readable-streams/cancel.html

[Build Bot]

Created attachment 267717 [details]
Archive of layout-test-results from ews105 for mac-yosemite-wk2

The attached test failures were seen while running run-webkit-tests on the mac-wk2-ews.
Bot: ews105  Port: mac-yosemite-wk2  Platform: Mac OS X 10.10.5

[Build Bot]

Comment on attachment 267714 [details]
Patch

Attachment 267714 [details] did not pass mac-debug-ews (mac):
Output: http://webkit-queues.webkit.org/results/584211

New failing tests:
imported/w3c/web-platform-tests/streams-api/readable-streams/cancel.html

[Build Bot]

Created attachment 267718 [details]
Archive of layout-test-results from ews116 for mac-yosemite

The attached test failures were seen while running run-webkit-tests on the mac-debug-ews.
Bot: ews116  Port: mac-yosemite  Platform: Mac OS X 10.10.5

[Xabier Rodríguez Calvar]

Created attachment 267743 [details]
Patch for landing

[Xabier Rodríguez Calvar]

(In reply to comment #17)
> Created attachment 267743 [details]
> Patch for landing

I rebased the patch and I am landing it as this patch was nothing to do with the workers issue at bug 152465.

[youenn fablet]

Thanks a lot!

[WebKit Commit Bot]

Comment on attachment 267743 [details]
Patch for landing

Rejecting attachment 267743 [details] from commit-queue.

Failed to run "['/Volumes/Data/EWS/WebKit/Tools/Scripts/webkit-patch', '--status-host=webkit-queues.webkit.org', '--bot-id=webkit-cq-01', 'land-attachment', '--force-clean', '--non-interactive', '--parent-command=commit-queue', 267743, '--port=mac']" exit_code: 2 cwd: /Volumes/Data/EWS/WebKit

Last 500 characters of output:
ted/w3c/ChangeLog
fatal: multiple stage entries for merged file 'LayoutTests/imported/w3c'

Failed to run "['git', 'commit', '--all', '-F', '-']" exit_code: 128 cwd: /Volumes/Data/EWS/WebKit

You have both LayoutTests/imported/w3c and LayoutTests/imported/w3c/ChangeLog
fatal: multiple stage entries for merged file 'LayoutTests/imported/w3c'

Failed to run "['git', 'commit', '--all', '-F', '-']" exit_code: 128 cwd: /Volumes/Data/EWS/WebKit
Updating OpenSource
Current branch master is up to date.

Full output: http://webkit-queues.webkit.org/results/588733

[Xabier Rodríguez Calvar]

Committed r194329: <http://trac.webkit.org/changeset/194329>