Bug 152065 - [Streams API] imported/w3c/web-platform-tests/streams-api/readable-streams/cancel.html has a flaky test
Summary: [Streams API] imported/w3c/web-platform-tests/streams-api/readable-streams/ca...
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: New Bugs (show other bugs)
Version: WebKit Nightly Build
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Xabier Rodríguez Calvar
URL:
Keywords:
Depends on: 152465
Blocks:
  Show dependency treegraph
 
Reported: 2015-12-09 06:58 PST by Xabier Rodríguez Calvar
Modified: 2015-12-21 07:15 PST (History)
5 users (show)

See Also:


Attachments
Patch (5.91 KB, patch)
2015-12-18 01:58 PST, Xabier Rodríguez Calvar
no flags Details | Formatted Diff | Diff
Patch (4.99 KB, patch)
2015-12-20 02:54 PST, youenn fablet
no flags Details | Formatted Diff | Diff
Archive of layout-test-results from webkit-cq-03 for mac-yosemite (681.71 KB, application/zip)
2015-12-20 04:12 PST, WebKit Commit Bot
no flags Details
Archive of layout-test-results from ews100 for mac-yosemite (703.22 KB, application/zip)
2015-12-20 05:21 PST, Build Bot
no flags Details
Archive of layout-test-results from ews105 for mac-yosemite-wk2 (742.14 KB, application/zip)
2015-12-20 05:25 PST, Build Bot
no flags Details
Archive of layout-test-results from ews116 for mac-yosemite (783.52 KB, application/zip)
2015-12-20 05:29 PST, Build Bot
no flags Details
Patch for landing (6.01 KB, patch)
2015-12-21 04:19 PST, Xabier Rodríguez Calvar
commit-queue: commit-queue-
Details | Formatted Diff | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Xabier Rodríguez Calvar 2015-12-09 06:58:00 PST
"ReadableStream cancellation: integration test on an infinite stream derived from a random push source" needs fixing.
Comment 1 Xabier Rodríguez Calvar 2015-12-14 01:34:30 PST
Checked with the spec and raised an issue in https://github.com/whatwg/streams/issues/413 as I think the error is timing error prone.
Comment 2 Xabier Rodríguez Calvar 2015-12-18 01:58:45 PST
Created attachment 267618 [details]
Patch
Comment 3 youenn fablet 2015-12-18 02:02:00 PST
Comment on attachment 267618 [details]
Patch

r=me
Comment 4 WebKit Commit Bot 2015-12-18 03:11:11 PST
Comment on attachment 267618 [details]
Patch

Clearing flags on attachment: 267618

Committed r194267: <http://trac.webkit.org/changeset/194267>
Comment 5 WebKit Commit Bot 2015-12-18 03:11:14 PST
All reviewed patches have been landed.  Closing bug.
Comment 6 WebKit Commit Bot 2015-12-20 02:23:59 PST
Re-opened since this is blocked by bug 152465
Comment 7 youenn fablet 2015-12-20 02:54:34 PST
Created attachment 267714 [details]
Patch
Comment 8 youenn fablet 2015-12-20 02:55:43 PST
(In reply to comment #7)
> Created attachment 267714 [details]
> Patch

Relanding after rebasing expected-text file according rollout of http://trac.webkit.org/changeset/194033
Comment 9 WebKit Commit Bot 2015-12-20 04:12:29 PST
Comment on attachment 267714 [details]
Patch

Rejecting attachment 267714 [details] from commit-queue.

New failing tests:
imported/w3c/web-platform-tests/streams-api/readable-streams/cancel.html
Full output: http://webkit-queues.webkit.org/results/584006
Comment 10 WebKit Commit Bot 2015-12-20 04:12:34 PST
Created attachment 267715 [details]
Archive of layout-test-results from webkit-cq-03 for mac-yosemite

The attached test failures were seen while running run-webkit-tests on the commit-queue.
Bot: webkit-cq-03  Port: mac-yosemite  Platform: Mac OS X 10.10.5
Comment 11 Build Bot 2015-12-20 05:21:42 PST
Comment on attachment 267714 [details]
Patch

Attachment 267714 [details] did not pass mac-ews (mac):
Output: http://webkit-queues.webkit.org/results/584222

New failing tests:
imported/w3c/web-platform-tests/streams-api/readable-streams/cancel.html
Comment 12 Build Bot 2015-12-20 05:21:45 PST
Created attachment 267716 [details]
Archive of layout-test-results from ews100 for mac-yosemite

The attached test failures were seen while running run-webkit-tests on the mac-ews.
Bot: ews100  Port: mac-yosemite  Platform: Mac OS X 10.10.5
Comment 13 Build Bot 2015-12-20 05:25:11 PST
Comment on attachment 267714 [details]
Patch

Attachment 267714 [details] did not pass mac-wk2-ews (mac-wk2):
Output: http://webkit-queues.webkit.org/results/584227

New failing tests:
imported/w3c/web-platform-tests/streams-api/readable-streams/cancel.html
Comment 14 Build Bot 2015-12-20 05:25:13 PST
Created attachment 267717 [details]
Archive of layout-test-results from ews105 for mac-yosemite-wk2

The attached test failures were seen while running run-webkit-tests on the mac-wk2-ews.
Bot: ews105  Port: mac-yosemite-wk2  Platform: Mac OS X 10.10.5
Comment 15 Build Bot 2015-12-20 05:29:55 PST
Comment on attachment 267714 [details]
Patch

Attachment 267714 [details] did not pass mac-debug-ews (mac):
Output: http://webkit-queues.webkit.org/results/584211

New failing tests:
imported/w3c/web-platform-tests/streams-api/readable-streams/cancel.html
Comment 16 Build Bot 2015-12-20 05:29:58 PST
Created attachment 267718 [details]
Archive of layout-test-results from ews116 for mac-yosemite

The attached test failures were seen while running run-webkit-tests on the mac-debug-ews.
Bot: ews116  Port: mac-yosemite  Platform: Mac OS X 10.10.5
Comment 17 Xabier Rodríguez Calvar 2015-12-21 04:19:54 PST
Created attachment 267743 [details]
Patch for landing
Comment 18 Xabier Rodríguez Calvar 2015-12-21 04:23:08 PST
(In reply to comment #17)
> Created attachment 267743 [details]
> Patch for landing

I rebased the patch and I am landing it as this patch was nothing to do with the workers issue at bug 152465.
Comment 19 youenn fablet 2015-12-21 04:29:49 PST
Thanks a lot!
Comment 20 WebKit Commit Bot 2015-12-21 05:18:12 PST
Comment on attachment 267743 [details]
Patch for landing

Rejecting attachment 267743 [details] from commit-queue.

Failed to run "['/Volumes/Data/EWS/WebKit/Tools/Scripts/webkit-patch', '--status-host=webkit-queues.webkit.org', '--bot-id=webkit-cq-01', 'land-attachment', '--force-clean', '--non-interactive', '--parent-command=commit-queue', 267743, '--port=mac']" exit_code: 2 cwd: /Volumes/Data/EWS/WebKit

Last 500 characters of output:
ted/w3c/ChangeLog
fatal: multiple stage entries for merged file 'LayoutTests/imported/w3c'

Failed to run "['git', 'commit', '--all', '-F', '-']" exit_code: 128 cwd: /Volumes/Data/EWS/WebKit

You have both LayoutTests/imported/w3c and LayoutTests/imported/w3c/ChangeLog
fatal: multiple stage entries for merged file 'LayoutTests/imported/w3c'

Failed to run "['git', 'commit', '--all', '-F', '-']" exit_code: 128 cwd: /Volumes/Data/EWS/WebKit
Updating OpenSource
Current branch master is up to date.

Full output: http://webkit-queues.webkit.org/results/588733
Comment 21 Xabier Rodríguez Calvar 2015-12-21 07:15:53 PST
Committed r194329: <http://trac.webkit.org/changeset/194329>