Bug 152014 – Web Inspector: Add a hidden property to TreeOutline

• Status: RESOLVED
• Resolution: FIXED
• Component: Web Inspector

[Matt Baker]

* SUMMARY
Add a hidden property to TreeOutline. Currently it's stored in the DOM only, in the form of a CSS class.

[Radar WebKit Bug Importer]

<rdar://problem/23809742>

[Matt Baker]

Created attachment 266940 [details]
[Patch] Proposed Fix

[Timothy Hatcher]

Comment on attachment 266940 [details]
[Patch] Proposed Fix

View in context: https://bugs.webkit.org/attachment.cgi?id=266940&action=review

> Source/WebInspectorUI/UserInterface/Views/TreeOutline.js:68
> +        this.element.classList.toggle("hidden", this._hidden);

We can actually switch to using the "hidden" property on DOM elements: this.hidden = this._hidden;

[Matt Baker]

(In reply to comment #3)
> Comment on attachment 266940 [details]
> [Patch] Proposed Fix
> 
> View in context:
> https://bugs.webkit.org/attachment.cgi?id=266940&action=review
> 
> > Source/WebInspectorUI/UserInterface/Views/TreeOutline.js:68
> > +        this.element.classList.toggle("hidden", this._hidden);
> 
> We can actually switch to using the "hidden" property on DOM elements:
> this.hidden = this._hidden;

Neat, I'll change it and file another bug for doing a find/replace on our other uses of "hidden".

[Matt Baker]

Created attachment 266944 [details]
[Patch] Proposed Fix

[WebKit Commit Bot]

Comment on attachment 266944 [details]
[Patch] Proposed Fix

Clearing flags on attachment: 266944

Committed r193791: <http://trac.webkit.org/changeset/193791>

[WebKit Commit Bot]

All reviewed patches have been landed.  Closing bug.