Bug 152014 - Web Inspector: Add a hidden property to TreeOutline
Summary: Web Inspector: Add a hidden property to TreeOutline
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: Web Inspector (show other bugs)
Version: WebKit Nightly Build
Hardware: All All
: P2 Normal
Assignee: Matt Baker
URL:
Keywords: InRadar
Depends on:
Blocks:
 
Reported: 2015-12-08 14:22 PST by Matt Baker
Modified: 2015-12-08 16:05 PST (History)
8 users (show)

See Also:


Attachments
[Patch] Proposed Fix (7.71 KB, patch)
2015-12-08 14:25 PST, Matt Baker
no flags Details | Formatted Diff | Diff
[Patch] Proposed Fix (9.87 KB, patch)
2015-12-08 15:17 PST, Matt Baker
no flags Details | Formatted Diff | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Matt Baker 2015-12-08 14:22:18 PST
* SUMMARY
Add a hidden property to TreeOutline. Currently it's stored in the DOM only, in the form of a CSS class.
Comment 1 Radar WebKit Bug Importer 2015-12-08 14:22:37 PST
<rdar://problem/23809742>
Comment 2 Matt Baker 2015-12-08 14:25:45 PST
Created attachment 266940 [details]
[Patch] Proposed Fix
Comment 3 Timothy Hatcher 2015-12-08 15:04:28 PST
Comment on attachment 266940 [details]
[Patch] Proposed Fix

View in context: https://bugs.webkit.org/attachment.cgi?id=266940&action=review

> Source/WebInspectorUI/UserInterface/Views/TreeOutline.js:68
> +        this.element.classList.toggle("hidden", this._hidden);

We can actually switch to using the "hidden" property on DOM elements: this.hidden = this._hidden;
Comment 4 Matt Baker 2015-12-08 15:08:46 PST
(In reply to comment #3)
> Comment on attachment 266940 [details]
> [Patch] Proposed Fix
> 
> View in context:
> https://bugs.webkit.org/attachment.cgi?id=266940&action=review
> 
> > Source/WebInspectorUI/UserInterface/Views/TreeOutline.js:68
> > +        this.element.classList.toggle("hidden", this._hidden);
> 
> We can actually switch to using the "hidden" property on DOM elements:
> this.hidden = this._hidden;

Neat, I'll change it and file another bug for doing a find/replace on our other uses of "hidden".
Comment 5 Matt Baker 2015-12-08 15:17:12 PST
Created attachment 266944 [details]
[Patch] Proposed Fix
Comment 6 WebKit Commit Bot 2015-12-08 16:05:06 PST
Comment on attachment 266944 [details]
[Patch] Proposed Fix

Clearing flags on attachment: 266944

Committed r193791: <http://trac.webkit.org/changeset/193791>
Comment 7 WebKit Commit Bot 2015-12-08 16:05:09 PST
All reviewed patches have been landed.  Closing bug.