Bug 152011 - DFG::UnificationPhase should merge isProfitableToUnbox, since this may have been set in ByteCodeParser
Summary: DFG::UnificationPhase should merge isProfitableToUnbox, since this may have b...
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: JavaScriptCore (show other bugs)
Version: WebKit Nightly Build
Hardware: All All
: P2 Normal
Assignee: Filip Pizlo
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2015-12-08 12:34 PST by Filip Pizlo
Modified: 2015-12-08 13:46 PST (History)
12 users (show)

See Also:

Attachments
the patch (2.98 KB, patch)
2015-12-08 12:37 PST, Filip Pizlo 		msaboff: review+
Details | Formatted Diff | Diff
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Filip Pizlo 2015-12-08 12:34:54 PST 
Previously UnificationPhase did not merge this because we used to only set this in FixupPhase, which runs after unification.  But now ByteCodeParser may set isProfitableToUnbox, so UnificationPhase needs to merge it after unifying.
Comment 1 Filip Pizlo 2015-12-08 12:37:00 PST 
Created attachment 266928 [details]
the patch
Comment 2 Michael Saboff 2015-12-08 13:18:17 PST 
Comment on attachment 266928 [details]
the patch

r=me
Comment 3 Filip Pizlo 2015-12-08 13:46:37 PST 
Landed in http://trac.webkit.org/changeset/193782