Bug 152005 - Remove OverridesHasInstance from TypeInfoFlags
Summary: Remove OverridesHasInstance from TypeInfoFlags
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: JavaScriptCore (show other bugs)
Version: WebKit Nightly Build
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Keith Miller
URL:
Keywords:
Depends on: 151839
Blocks:
  Show dependency treegraph
 
Reported: 2015-12-08 12:03 PST by Keith Miller
Modified: 2015-12-22 12:05 PST (History)
6 users (show)

See Also:


Attachments
Patch (22.30 KB, patch)
2015-12-18 19:00 PST, Keith Miller
no flags Details | Formatted Diff | Diff
Patch (22.67 KB, patch)
2015-12-18 20:02 PST, Keith Miller
no flags Details | Formatted Diff | Diff
Patch (22.70 KB, patch)
2015-12-21 09:53 PST, Keith Miller
no flags Details | Formatted Diff | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Keith Miller 2015-12-08 12:03:29 PST
This bit is no longer used in any runtime code and should be freed for others to use.
Comment 1 Keith Miller 2015-12-18 19:00:57 PST
Created attachment 267676 [details]
Patch
Comment 2 WebKit Commit Bot 2015-12-18 19:01:49 PST
Attachment 267676 [details] did not pass style-queue:


ERROR: Source/JavaScriptCore/llint/LLIntData.cpp:154:  Tests for true/false, null/non-null, and zero/non-zero should all be done without equality comparisons.  [readability/comparison_to_zero] [5]
Total errors found: 1 in 15 files


If any of these errors are false positives, please file a bug against check-webkit-style.
Comment 3 Keith Miller 2015-12-18 20:02:31 PST
Created attachment 267678 [details]
Patch
Comment 4 WebKit Commit Bot 2015-12-18 20:04:21 PST
Attachment 267678 [details] did not pass style-queue:


ERROR: Source/JavaScriptCore/llint/LLIntData.cpp:152:  Tests for true/false, null/non-null, and zero/non-zero should all be done without equality comparisons.  [readability/comparison_to_zero] [5]
Total errors found: 1 in 15 files


If any of these errors are false positives, please file a bug against check-webkit-style.
Comment 5 Keith Miller 2015-12-21 09:53:57 PST
Created attachment 267752 [details]
Patch
Comment 6 WebKit Commit Bot 2015-12-21 09:56:21 PST
Attachment 267752 [details] did not pass style-queue:


ERROR: Source/JavaScriptCore/llint/LLIntData.cpp:152:  Tests for true/false, null/non-null, and zero/non-zero should all be done without equality comparisons.  [readability/comparison_to_zero] [5]
Total errors found: 1 in 15 files


If any of these errors are false positives, please file a bug against check-webkit-style.
Comment 7 Keith Miller 2015-12-21 09:57:22 PST
Comment on attachment 267752 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=267752&action=review

> Source/JavaScriptCore/llint/LLIntData.cpp:152
> +    STATIC_ASSERT(GlobalCode == 0);

This is intentionally compared with 0 so the static_assert message is clearer.
Comment 8 Saam Barati 2015-12-21 15:02:41 PST
Comment on attachment 267752 [details]
Patch

r=me
Comment 9 WebKit Commit Bot 2015-12-22 12:05:21 PST
Comment on attachment 267752 [details]
Patch

Clearing flags on attachment: 267752

Committed r194369: <http://trac.webkit.org/changeset/194369>
Comment 10 WebKit Commit Bot 2015-12-22 12:05:26 PST
All reviewed patches have been landed.  Closing bug.