Bug 152000 – [MediaStream] MediaDeviceInfo.label must be empty unless the user has granted permission to access device

• Status: RESOLVED
• Resolution: FIXED
• Component: Media

[Eric Carlson]

MediaDeviceInfo.label must be empty if none of the local devices are attached to an active MediaStreamTrack in the current browsing context, and if no persistent permission to access the devices has been granted to the page's origin.

[Eric Carlson]

Created attachment 267850 [details]
Proposed patch.

Include label when the document has had an active media stream track.

[Radar WebKit Bug Importer]

<rdar://problem/24001637>

[Brent Fulgham]

Comment on attachment 267850 [details]
Proposed patch.

View in context: https://bugs.webkit.org/attachment.cgi?id=267850&action=review

Looks good. I had a couple of minor nits below.

> Source/WebCore/ChangeLog:28
> +        (WebCore::mediaStreams): Deleted. Drive-by cleanup: moved list of all streams MediaStreamRegistry.

moved list of all streams *to* MediaStreamRegistry?

> Source/WebCore/Modules/mediastream/MediaStream.cpp:240
> +    if (Document *document = downcast<Document>(scriptExecutionContext()))

Document* document!

[Eric Carlson]

(In reply to comment #3)
> Comment on attachment 267850 [details]
>
> > Source/WebCore/ChangeLog:28
> > +        (WebCore::mediaStreams): Deleted. Drive-by cleanup: moved list of all streams MediaStreamRegistry.
> 
> moved list of all streams *to* MediaStreamRegistry?
> 
Fixed.

> > Source/WebCore/Modules/mediastream/MediaStream.cpp:240
> > +    if (Document *document = downcast<Document>(scriptExecutionContext()))
> 
> Document* document!
Oops, fixed.

Thanks!

[Eric Carlson]

Committed r194397: https://trac.webkit.org/r194397