Bug 151996 - [iOS] Adopt WebFullScreenVideoRootViewController.
Summary: [iOS] Adopt WebFullScreenVideoRootViewController.
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: New Bugs (show other bugs)
Version: WebKit Nightly Build
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Jer Noble
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2015-12-08 09:59 PST by Jer Noble
Modified: 2015-12-08 11:15 PST (History)
2 users (show)

See Also:

Attachments
Patch (3.17 KB, patch)
2015-12-08 10:03 PST, Jer Noble 		mitz: review+
Details | Formatted Diff | Diff
Patch for landing (3.12 KB, patch)
2015-12-08 10:28 PST, Jer Noble 		no flags Details | Formatted Diff | Diff
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Jer Noble 2015-12-08 09:59:07 PST 
[iOS] Adopt WebFullScreenVideoRootViewController.
Comment 1 Jer Noble 2015-12-08 10:03:26 PST 
Created attachment 266902 [details]
Patch
Comment 2 WebKit Commit Bot 2015-12-08 10:04:54 PST 
Attachment 266902 [details] did not pass style-queue:


ERROR: Source/WebCore/platform/ios/WebVideoFullscreenInterfaceAVKit.mm:84:  *SoftLink.h header should be included after all other headers.  [build/include_order] [4]
ERROR: Source/WebCore/platform/ios/WebVideoFullscreenInterfaceAVKit.mm:94:  Missing space before {  [whitespace/braces] [5]
Total errors found: 2 in 2 files


If any of these errors are false positives, please file a bug against check-webkit-style.
Comment 3 mitz 2015-12-08 10:09:11 PST 
Comment on attachment 266902 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=266902&action=review

> Source/WebCore/platform/ios/WebVideoFullscreenInterfaceAVKit.mm:83
> +#if __has_include(<WebKitAdditions/WebFullScreenVideoRootViewController.m>)

Instead of checking for the presence of the header, you should check for __IPHONE_OS_VERSION_MIN_REQUIRED >= 101200 && USE(APPLE_INTERNAL_SDK).
Comment 4 mitz 2015-12-08 10:13:59 PST 
(In reply to comment #3)
> Instead of checking for the presence of the header, you should check for
> __IPHONE_OS_VERSION_MIN_REQUIRED >= 101200 && USE(APPLE_INTERNAL_SDK).

Sorry, ignore the __IPHONE_OS_VERSION_MIN_REQUIRED part! Just check for USE(APPLE_INTERNAL_SDK).
Comment 5 Jer Noble 2015-12-08 10:28:06 PST 
Created attachment 266907 [details]
Patch for landing
Comment 6 WebKit Commit Bot 2015-12-08 11:09:51 PST 
Attachment 266907 [details] did not pass style-queue:


ERROR: Source/WebCore/platform/ios/WebVideoFullscreenInterfaceAVKit.mm:84:  *SoftLink.h header should be included after all other headers.  [build/include_order] [4]
ERROR: Source/WebCore/platform/ios/WebVideoFullscreenInterfaceAVKit.mm:94:  Missing space before {  [whitespace/braces] [5]
Total errors found: 2 in 2 files


If any of these errors are false positives, please file a bug against check-webkit-style.
Comment 7 Jer Noble 2015-12-08 11:11:29 PST 
Committed r193760: <http://trac.webkit.org/changeset/193760>