Bug 151960 - [WK2] Regression(r187691): If a page is showing an auth pane in one tab, any new tabs with same page hang until credentials are entered in first tab
Summary: [WK2] Regression(r187691): If a page is showing an auth pane in one tab, any ...
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: WebKit2 (show other bugs)
Version: WebKit Nightly Build
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Chris Dumez
URL:
Keywords: InRadar
Depends on:
Blocks:
 
Reported: 2015-12-07 12:56 PST by Chris Dumez
Modified: 2015-12-07 14:44 PST (History)
6 users (show)

See Also:


Attachments
Patch (7.68 KB, patch)
2015-12-07 13:02 PST, Chris Dumez
no flags Details | Formatted Diff | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Chris Dumez 2015-12-07 12:56:17 PST
If a page is showing an auth pane in one tab, any new tabs with same page hang until credentials are entered in first tab. This is a regression from <http://trac.webkit.org/changeset/187691>.
Comment 1 Chris Dumez 2015-12-07 12:56:44 PST
rdar://problem/23618112
Comment 2 Chris Dumez 2015-12-07 13:02:19 PST
Created attachment 266800 [details]
Patch
Comment 3 Alex Christensen 2015-12-07 13:06:04 PST
Comment on attachment 266800 [details]
Patch

r=me
Comment 4 Alexey Proskuryakov 2015-12-07 13:16:11 PST
Comment on attachment 266800 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=266800&action=review

> Source/WebKit2/ChangeLog:14
> +        same domain, no matter what tab they are for. This can be confusing
> +        so we now only coalesce authentication challenges within each tab,
> +        by leveraging the pageID (in addition to the domain).

Hmm, so this means that the user will once again get a ton of authentication requests when relaunching Safari. That's not a good experience either.
Comment 5 Chris Dumez 2015-12-07 13:20:50 PST
(In reply to comment #4)
> Comment on attachment 266800 [details]
> Patch
> 
> View in context:
> https://bugs.webkit.org/attachment.cgi?id=266800&action=review
> 
> > Source/WebKit2/ChangeLog:14
> > +        same domain, no matter what tab they are for. This can be confusing
> > +        so we now only coalesce authentication challenges within each tab,
> > +        by leveraging the pageID (in addition to the domain).
> 
> Hmm, so this means that the user will once again get a ton of authentication
> requests when relaunching Safari. That's not a good experience either.

Well, before coalescing, they would get several auth panes per tab. Now they can get maximum one auth pane per tab. I think this is a good compromise.

The situation where you end up having blank tabs stuck due to an authentication request in another tab (that is not visible) is worse IMHO.
Comment 6 WebKit Commit Bot 2015-12-07 14:44:52 PST
Comment on attachment 266800 [details]
Patch

Clearing flags on attachment: 266800

Committed r193654: <http://trac.webkit.org/changeset/193654>
Comment 7 WebKit Commit Bot 2015-12-07 14:44:57 PST
All reviewed patches have been landed.  Closing bug.