Bug 151956 - Update options for benchmark
Summary: Update options for benchmark
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: Animations (show other bugs)
Version: WebKit Nightly Build
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Jon Lee
URL:
Keywords: InRadar
Depends on:
Blocks:
 
Reported: 2015-12-07 12:37 PST by Jon Lee
Modified: 2015-12-07 14:14 PST (History)
7 users (show)

See Also:


Attachments
Patch (16.70 KB, patch)
2015-12-07 12:59 PST, Jon Lee
simon.fraser: review+
Details | Formatted Diff | Diff
Patch for landing (16.79 KB, patch)
2015-12-07 13:28 PST, Jon Lee
no flags Details | Formatted Diff | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Jon Lee 2015-12-07 12:37:29 PST
Merge some of the checkbox-based options into radio groups, and add a way to remove the border display
Comment 1 Radar WebKit Bug Importer 2015-12-07 12:41:21 PST
<rdar://problem/23788273>
Comment 2 Jon Lee 2015-12-07 12:59:47 PST
Created attachment 266799 [details]
Patch
Comment 3 Simon Fraser (smfr) 2015-12-07 13:03:45 PST
Comment on attachment 266799 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=266799&action=review

> PerformanceTests/Animometer/runner/resources/animometer.js:146
> +        var formElement = document.forms[0].elements[name];

Should we give the form a name rather than using forms[0]?

> PerformanceTests/Animometer/runner/resources/animometer.js:154
> +        var formElements = document.forms[0].elements;

Ditto.

> PerformanceTests/Animometer/runner/resources/animometer.js:176
> +        var formElements = document.forms[0].elements;

Ditto.
Comment 4 Jon Lee 2015-12-07 13:24:33 PST
(In reply to comment #3)
> Comment on attachment 266799 [details]
> Patch
> 
> View in context:
> https://bugs.webkit.org/attachment.cgi?id=266799&action=review
> 
> > PerformanceTests/Animometer/runner/resources/animometer.js:146
> > +        var formElement = document.forms[0].elements[name];
> 
> Should we give the form a name rather than using forms[0]?
> 
> > PerformanceTests/Animometer/runner/resources/animometer.js:154
> > +        var formElements = document.forms[0].elements;
> 
> Ditto.
> 
> > PerformanceTests/Animometer/runner/resources/animometer.js:176
> > +        var formElements = document.forms[0].elements;
> 
> Ditto.

I changed it to use a name instead.

Thanks!
Comment 5 Jon Lee 2015-12-07 13:28:04 PST
Created attachment 266802 [details]
Patch for landing
Comment 6 WebKit Commit Bot 2015-12-07 14:14:45 PST
Comment on attachment 266802 [details]
Patch for landing

Clearing flags on attachment: 266802

Committed r193650: <http://trac.webkit.org/changeset/193650>
Comment 7 WebKit Commit Bot 2015-12-07 14:14:50 PST
All reviewed patches have been landed.  Closing bug.