Bug 151956 – Update options for benchmark

• Status: RESOLVED
• Resolution: FIXED
• Component: Animations

[Jon Lee]

Merge some of the checkbox-based options into radio groups, and add a way to remove the border display

[Radar WebKit Bug Importer]

<rdar://problem/23788273>

[Jon Lee]

Created attachment 266799 [details]
Patch

[Simon Fraser (smfr)]

Comment on attachment 266799 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=266799&action=review

> PerformanceTests/Animometer/runner/resources/animometer.js:146
> +        var formElement = document.forms[0].elements[name];

Should we give the form a name rather than using forms[0]?

> PerformanceTests/Animometer/runner/resources/animometer.js:154
> +        var formElements = document.forms[0].elements;

Ditto.

> PerformanceTests/Animometer/runner/resources/animometer.js:176
> +        var formElements = document.forms[0].elements;

Ditto.

[Jon Lee]

(In reply to comment #3)
> Comment on attachment 266799 [details]
> Patch
> 
> View in context:
> https://bugs.webkit.org/attachment.cgi?id=266799&action=review
> 
> > PerformanceTests/Animometer/runner/resources/animometer.js:146
> > +        var formElement = document.forms[0].elements[name];
> 
> Should we give the form a name rather than using forms[0]?
> 
> > PerformanceTests/Animometer/runner/resources/animometer.js:154
> > +        var formElements = document.forms[0].elements;
> 
> Ditto.
> 
> > PerformanceTests/Animometer/runner/resources/animometer.js:176
> > +        var formElements = document.forms[0].elements;
> 
> Ditto.

I changed it to use a name instead.

Thanks!

[Jon Lee]

Created attachment 266802 [details]
Patch for landing

[WebKit Commit Bot]

Comment on attachment 266802 [details]
Patch for landing

Clearing flags on attachment: 266802

Committed r193650: <http://trac.webkit.org/changeset/193650>

[WebKit Commit Bot]

All reviewed patches have been landed.  Closing bug.