RESOLVED FIXED 151955
FTL B3 should be able to flag the tag constants as being super important so that B3 can hoist them and Air can force them into registers 
https://bugs.webkit.org/show_bug.cgi?id=151955
Summary FTL B3 should be able to flag the tag constants as being super important so t...
Filip Pizlo
Reported 2015-12-07 12:27:39 PST
Patch forthcoming.
Attachments
work in progress (29.60 KB, patch)
2015-12-07 13:05 PST, Filip Pizlo 		no flags
DetailsFormatted DiffDiff
it's starting to work (33.29 KB, patch)
2015-12-07 16:05 PST, Filip Pizlo 		no flags
DetailsFormatted DiffDiff
the patch (40.47 KB, patch)
2015-12-07 16:37 PST, Filip Pizlo 		no flags
DetailsFormatted DiffDiff
the patch (40.46 KB, patch)
2015-12-07 16:38 PST, Filip Pizlo 		ggaren: review+
DetailsFormatted DiffDiff
Show Obsolete (3) View All Add attachment proposed patch, testcase, etc.
Filip Pizlo
Comment 1 2015-12-07 13:05:38 PST
Created attachment 266801 [details] work in progress
Filip Pizlo
Comment 2 2015-12-07 16:05:00 PST
Created attachment 266825 [details] it's starting to work
Filip Pizlo
Comment 3 2015-12-07 16:37:34 PST
Created attachment 266831 [details] the patch
Filip Pizlo
Comment 4 2015-12-07 16:38:51 PST
Created attachment 266832 [details] the patch For real this time.
Geoffrey Garen
Comment 5 2015-12-07 16:53:54 PST
Comment on attachment 266832 [details] the patch View in context: https://bugs.webkit.org/attachment.cgi?id=266832&action=review r=me > Source/JavaScriptCore/b3/B3CFG.h:39 > +public: WTF_MAKE_FAST_ALLOCATED
Filip Pizlo
Comment 6 2015-12-07 18:46:15 PST
(In reply to comment #5) > Comment on attachment 266832 [details] > the patch > > View in context: > https://bugs.webkit.org/attachment.cgi?id=266832&action=review > > r=me > > > Source/JavaScriptCore/b3/B3CFG.h:39 > > +public: > > WTF_MAKE_FAST_ALLOCATED Fixed!
Filip Pizlo
Comment 7 2015-12-07 18:47:14 PST
Landed in http://trac.webkit.org/changeset/193682
Csaba Osztrogonác
Comment 8 2015-12-08 01:42:15 PST
(In reply to comment #7) > Landed in http://trac.webkit.org/changeset/193682 It broke the WinCairo build: https://build.webkit.org/builders/WinCairo%2064-Bit%20Release/builds/51858 (cc-ing port maintainers)
Note You need to log in before you can comment on or make changes to this bug.