Bug 151945 - Rename JITBitwiseBinaryOpGenerator to JITBitBinaryOpGenerator.
Summary: Rename JITBitwiseBinaryOpGenerator to JITBitBinaryOpGenerator.
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: JavaScriptCore (show other bugs)
Version: WebKit Local Build
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Mark Lam
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2015-12-07 09:19 PST by Mark Lam
Modified: 2015-12-07 09:32 PST (History)
4 users (show)

See Also:


Attachments
proposed patch. (20.23 KB, patch)
2015-12-07 09:27 PST, Mark Lam
saam: review+
Details | Formatted Diff | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Mark Lam 2015-12-07 09:19:15 PST
The lshift operator also need to inherit from JITBitBinaryOpGenerator.  Calling it "BitBinaryOp" makes more sense than "BitwiseBinaryOp" in that case, and still makes sense for the bitand, bitor, and bitxor operators.
Comment 1 Mark Lam 2015-12-07 09:27:36 PST
Created attachment 266781 [details]
proposed patch.
Comment 2 Saam Barati 2015-12-07 09:29:26 PST
Comment on attachment 266781 [details]
proposed patch.

LGTM
Comment 3 WebKit Commit Bot 2015-12-07 09:30:03 PST
Attachment 266781 [details] did not pass style-queue:


ERROR: Source/JavaScriptCore/jit/JITBitOrGenerator.h:39:  Wrong number of spaces before statement. (expected: 12)  [whitespace/indent] [4]
ERROR: Source/JavaScriptCore/jit/JITBitAndGenerator.h:39:  Wrong number of spaces before statement. (expected: 12)  [whitespace/indent] [4]
ERROR: Source/JavaScriptCore/jit/JITBitBinaryOpGenerator.h:40:  Wrong number of spaces before statement. (expected: 12)  [whitespace/indent] [4]
ERROR: Source/JavaScriptCore/jit/JITBitBinaryOpGenerator.h:41:  Wrong number of spaces before statement. (expected: 12)  [whitespace/indent] [4]
ERROR: Source/JavaScriptCore/jit/JITBitBinaryOpGenerator.h:42:  Wrong number of spaces before statement. (expected: 12)  [whitespace/indent] [4]
ERROR: Source/JavaScriptCore/jit/JITBitBinaryOpGenerator.h:43:  Wrong number of spaces before statement. (expected: 12)  [whitespace/indent] [4]
ERROR: Source/JavaScriptCore/jit/JITBitBinaryOpGenerator.h:44:  Wrong number of spaces before statement. (expected: 12)  [whitespace/indent] [4]
ERROR: Source/JavaScriptCore/jit/JITBitBinaryOpGenerator.h:45:  Wrong number of spaces before statement. (expected: 12)  [whitespace/indent] [4]
ERROR: Source/JavaScriptCore/jit/JITBitXorGenerator.h:39:  Wrong number of spaces before statement. (expected: 12)  [whitespace/indent] [4]
Total errors found: 9 in 10 files


If any of these errors are false positives, please file a bug against check-webkit-style.
Comment 4 Mark Lam 2015-12-07 09:32:55 PST
Thanks for the review.  Landed in r193633: <http://trac.webkit.org/r193633>.