RESOLVED FIXED151945
Rename JITBitwiseBinaryOpGenerator to JITBitBinaryOpGenerator. 
https://bugs.webkit.org/show_bug.cgi?id=151945
Summary Rename JITBitwiseBinaryOpGenerator to JITBitBinaryOpGenerator.
Mark Lam
Reported 2015-12-07 09:19:15 PST
The lshift operator also need to inherit from JITBitBinaryOpGenerator. Calling it "BitBinaryOp" makes more sense than "BitwiseBinaryOp" in that case, and still makes sense for the bitand, bitor, and bitxor operators.
Attachments
proposed patch. (20.23 KB, patch)
2015-12-07 09:27 PST, Mark Lam 		saam: review+
DetailsFormatted DiffDiff
View All Add attachment proposed patch, testcase, etc.
Mark Lam
Comment 1 2015-12-07 09:27:36 PST
Created attachment 266781 [details] proposed patch.
Saam Barati
Comment 2 2015-12-07 09:29:26 PST
Comment on attachment 266781 [details] proposed patch. LGTM
WebKit Commit Bot
Comment 3 2015-12-07 09:30:03 PST
Attachment 266781 [details] did not pass style-queue: ERROR: Source/JavaScriptCore/jit/JITBitOrGenerator.h:39: Wrong number of spaces before statement. (expected: 12) [whitespace/indent] [4] ERROR: Source/JavaScriptCore/jit/JITBitAndGenerator.h:39: Wrong number of spaces before statement. (expected: 12) [whitespace/indent] [4] ERROR: Source/JavaScriptCore/jit/JITBitBinaryOpGenerator.h:40: Wrong number of spaces before statement. (expected: 12) [whitespace/indent] [4] ERROR: Source/JavaScriptCore/jit/JITBitBinaryOpGenerator.h:41: Wrong number of spaces before statement. (expected: 12) [whitespace/indent] [4] ERROR: Source/JavaScriptCore/jit/JITBitBinaryOpGenerator.h:42: Wrong number of spaces before statement. (expected: 12) [whitespace/indent] [4] ERROR: Source/JavaScriptCore/jit/JITBitBinaryOpGenerator.h:43: Wrong number of spaces before statement. (expected: 12) [whitespace/indent] [4] ERROR: Source/JavaScriptCore/jit/JITBitBinaryOpGenerator.h:44: Wrong number of spaces before statement. (expected: 12) [whitespace/indent] [4] ERROR: Source/JavaScriptCore/jit/JITBitBinaryOpGenerator.h:45: Wrong number of spaces before statement. (expected: 12) [whitespace/indent] [4] ERROR: Source/JavaScriptCore/jit/JITBitXorGenerator.h:39: Wrong number of spaces before statement. (expected: 12) [whitespace/indent] [4] Total errors found: 9 in 10 files If any of these errors are false positives, please file a bug against check-webkit-style.
Mark Lam
Comment 4 2015-12-07 09:32:55 PST
Thanks for the review. Landed in r193633: <http://trac.webkit.org/r193633>.
Note You need to log in before you can comment on or make changes to this bug.