RESOLVED FIXED 151900
Crash when secondary clicking on a link on yahoo.com 
https://bugs.webkit.org/show_bug.cgi?id=151900
Summary Crash when secondary clicking on a link on yahoo.com
Anders Carlsson
Reported 2015-12-04 17:36:45 PST
Crash when secondary clicking on a link on yahoo.com
Attachments
Patch (2.14 KB, patch)
2015-12-04 17:38 PST, Anders Carlsson 		bdakin: review+
DetailsFormatted DiffDiff
View All Add attachment proposed patch, testcase, etc.
Anders Carlsson
Comment 1 2015-12-04 17:38:00 PST
Created attachment 266693 [details] Patch
Anders Carlsson
Comment 2 2015-12-04 17:45:42 PST
Committed r193499: <http://trac.webkit.org/changeset/193499>
Darin Adler
Comment 3 2015-12-07 10:59:41 PST
Comment on attachment 266693 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=266693&action=review > Source/WebKit2/UIProcess/mac/WebContextMenuProxyMac.mm:271 > + auto absoluteLinkURL = URL(ParsedURLString, hitTestData.absoluteLinkURL); I’m a bit surprised at the use of ParsedURLString here. Does this string com from something that the WebCore URL class produced in the other process that was shipped over by XPC? If so, then I suppose ParsedURLString is correct, but I worry slight if the URL “can be trusted” and thus how the use of ParsedURLString might be risky in some way.
Note You need to log in before you can comment on or make changes to this bug.