Bug 151884 - [Cocoa] Some fonts cause CTFontCopyAvailableTables() to return nullptr
Summary: [Cocoa] Some fonts cause CTFontCopyAvailableTables() to return nullptr
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: New Bugs (show other bugs)
Version: WebKit Nightly Build
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Myles C. Maxfield
URL:
Keywords: InRadar
Depends on:
Blocks:
 
Reported: 2015-12-04 14:04 PST by Myles C. Maxfield
Modified: 2016-01-04 13:27 PST (History)
8 users (show)

See Also:

Attachments
Patch (1.55 KB, patch)
2015-12-04 14:05 PST, Myles C. Maxfield 		no flags Details | Formatted Diff | Diff
Patch (1.59 KB, patch)
2015-12-04 14:07 PST, Myles C. Maxfield 		no flags Details | Formatted Diff | Diff
Show Obsolete (1) View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Myles C. Maxfield 2015-12-04 14:04:56 PST 
[Cocoa] Some fonts cause CTFontCopyAvailableTables() to return nullptr
Comment 1 Myles C. Maxfield 2015-12-04 14:05:47 PST 
Created attachment 266659 [details]
Patch
Comment 2 Myles C. Maxfield 2015-12-04 14:06:54 PST 
<rdar://problem/23752253>
Comment 3 Myles C. Maxfield 2015-12-04 14:07:25 PST 
Created attachment 266660 [details]
Patch
Comment 4 Myles C. Maxfield 2015-12-04 14:14:38 PST 
fredw says there may be similar code elsewhere that needs to be updated.
Comment 5 Myles C. Maxfield 2015-12-04 14:16:34 PST 
fontHasVerticalGlyphs()
Comment 6 BJ Burg 2015-12-04 15:03:08 PST 
Comment on attachment 266660 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=266660&action=review

rs=me

> Source/WebCore/platform/graphics/opentype/OpenTypeCG.cpp:44
>      CFIndex numTables = CFArrayGetCount(tableTags.get());

I would add a newline below the return. Not sure how dense your corner of WebKit is. :)
Comment 7 WebKit Commit Bot 2015-12-04 15:52:44 PST 
Comment on attachment 266660 [details]
Patch

Clearing flags on attachment: 266660

Committed r193484: <http://trac.webkit.org/changeset/193484>
Comment 8 WebKit Commit Bot 2015-12-04 15:52:47 PST 
All reviewed patches have been landed.  Closing bug.
Comment 9 Myles C. Maxfield 2016-01-04 13:27:29 PST 
Committed r194551: <http://trac.webkit.org/changeset/194551>