Bug 151883 – Progress towards implementing downloads with NetworkSession

• Status: RESOLVED
• Resolution: FIXED
• Component: New Bugs

[Alex Christensen]

Progress towards implementing downloads with NetworkSession

[Alex Christensen]

Created attachment 266657 [details]
Patch

[Alex Christensen]

Created attachment 266661 [details]
Patch

[Brady Eidson]

Comment on attachment 266661 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=266661&action=review

> Source/WebKit2/NetworkProcess/NetworkSession.h:-106
> -    ~NetworkSession() { ASSERT(m_dataTaskMap.isEmpty()); }

This ASSERT seems to be missing from the new ~NetworkSession. Intentional?

> Source/WebKit2/NetworkProcess/cocoa/NetworkSessionCocoa.mm:226
> +    [m_session invalidateAndCancel];

The ASSERT I mentioned above seems to be missing here. Intentional?

[Alex Christensen]

(In reply to comment #3)
> Comment on attachment 266661 [details]
> Patch
> 
> View in context:
> https://bugs.webkit.org/attachment.cgi?id=266661&action=review
> 
> > Source/WebKit2/NetworkProcess/NetworkSession.h:-106
> > -    ~NetworkSession() { ASSERT(m_dataTaskMap.isEmpty()); }
> 
> This ASSERT seems to be missing from the new ~NetworkSession. Intentional?
Yes, intentional.  That is because I was running into destroyed network sessions that had data tasks still, so I call [m_session invalidateAndCancel]

[WebKit Commit Bot]

Comment on attachment 266661 [details]
Patch

Clearing flags on attachment: 266661

Committed r193787: <http://trac.webkit.org/changeset/193787>

[WebKit Commit Bot]

All reviewed patches have been landed.  Closing bug.