Bug 151883 - Progress towards implementing downloads with NetworkSession
Summary: Progress towards implementing downloads with NetworkSession
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: New Bugs (show other bugs)
Version: WebKit Nightly Build
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Alex Christensen
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2015-12-04 13:57 PST by Alex Christensen
Modified: 2015-12-08 15:06 PST (History)
3 users (show)

See Also:

Attachments
Patch (16.95 KB, patch)
2015-12-04 13:57 PST, Alex Christensen 		no flags Details | Formatted Diff | Diff
Patch (17.16 KB, patch)
2015-12-04 14:11 PST, Alex Christensen 		no flags Details | Formatted Diff | Diff
Show Obsolete (1) View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Alex Christensen 2015-12-04 13:57:32 PST 
Progress towards implementing downloads with NetworkSession
Comment 1 Alex Christensen 2015-12-04 13:57:53 PST 
Created attachment 266657 [details]
Patch
Comment 2 Alex Christensen 2015-12-04 14:11:29 PST 
Created attachment 266661 [details]
Patch
Comment 3 Brady Eidson 2015-12-08 13:52:50 PST 
Comment on attachment 266661 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=266661&action=review

> Source/WebKit2/NetworkProcess/NetworkSession.h:-106
> -    ~NetworkSession() { ASSERT(m_dataTaskMap.isEmpty()); }

This ASSERT seems to be missing from the new ~NetworkSession. Intentional?

> Source/WebKit2/NetworkProcess/cocoa/NetworkSessionCocoa.mm:226
> +    [m_session invalidateAndCancel];

The ASSERT I mentioned above seems to be missing here. Intentional?
Comment 4 Alex Christensen 2015-12-08 14:20:10 PST 
(In reply to comment #3)
> Comment on attachment 266661 [details]
> Patch
> 
> View in context:
> https://bugs.webkit.org/attachment.cgi?id=266661&action=review
> 
> > Source/WebKit2/NetworkProcess/NetworkSession.h:-106
> > -    ~NetworkSession() { ASSERT(m_dataTaskMap.isEmpty()); }
> 
> This ASSERT seems to be missing from the new ~NetworkSession. Intentional?
Yes, intentional.  That is because I was running into destroyed network sessions that had data tasks still, so I call [m_session invalidateAndCancel]
Comment 5 WebKit Commit Bot 2015-12-08 15:06:12 PST 
Comment on attachment 266661 [details]
Patch

Clearing flags on attachment: 266661

Committed r193787: <http://trac.webkit.org/changeset/193787>
Comment 6 WebKit Commit Bot 2015-12-08 15:06:16 PST 
All reviewed patches have been landed.  Closing bug.