RESOLVED FIXED 151866
Web Inspector: debugger popover should have source location link when showing function source 
https://bugs.webkit.org/show_bug.cgi?id=151866
Summary Web Inspector: debugger popover should have source location link when showing...
Blaze Burg
Reported 2015-12-04 10:01:52 PST
Created attachment 266634 [details] [Screenshot] No hyperlink Currently the popover shows the function's name, but it's not a hyperlink. Listing the enclosing scope would be nice too, but a hyperlink is better. Ideally this would show the same function in the Debugger tab, so that the user can set breakpoints right away and the content view navigation is added to the same tab.
Attachments
[Screenshot] No hyperlink (416.17 KB, image/png)
2015-12-04 10:01 PST, Blaze Burg 		no flags
Details
[Image] Popover w/ hyperlink (270.40 KB, image/png)
2015-12-10 13:08 PST, Matt Baker 		no flags
Details
[Patch] Proposed Fix (2.77 KB, patch)
2015-12-10 13:10 PST, Matt Baker 		no flags
DetailsFormatted DiffDiff
[Patch] Proposed Fix (3.25 KB, patch)
2015-12-10 13:48 PST, Matt Baker 		no flags
DetailsFormatted DiffDiff
[Patch] Proposed Fix (3.25 KB, patch)
2015-12-10 13:50 PST, Matt Baker 		no flags
DetailsFormatted DiffDiff
Show Obsolete (2) View All Add attachment proposed patch, testcase, etc.
Radar WebKit Bug Importer
Comment 1 2015-12-04 10:02:38 PST
<rdar://problem/23762056>
Matt Baker
Comment 2 2015-12-10 13:08:28 PST
Created attachment 267124 [details] [Image] Popover w/ hyperlink
Matt Baker
Comment 3 2015-12-10 13:10:17 PST
Created attachment 267125 [details] [Patch] Proposed Fix
Blaze Burg
Comment 4 2015-12-10 13:22:16 PST
Comment on attachment 267125 [details] [Patch] Proposed Fix View in context: https://bugs.webkit.org/attachment.cgi?id=267125&action=review nice! > Source/WebInspectorUI/UserInterface/Views/SourceCodeTextEditor.js:1463 > wrapper.className = "body formatted-function"; pls convert to use classList API.
Matt Baker
Comment 5 2015-12-10 13:48:26 PST
Created attachment 267127 [details] [Patch] Proposed Fix
Matt Baker
Comment 6 2015-12-10 13:50:57 PST
Created attachment 267129 [details] [Patch] Proposed Fix
WebKit Commit Bot
Comment 7 2015-12-10 14:38:35 PST
Comment on attachment 267129 [details] [Patch] Proposed Fix Clearing flags on attachment: 267129 Committed r193926: <http://trac.webkit.org/changeset/193926>
WebKit Commit Bot
Comment 8 2015-12-10 14:38:40 PST
All reviewed patches have been landed. Closing bug.
Note You need to log in before you can comment on or make changes to this bug.